fix(frontend): align drawer with app frame and polish enter animation - #15542
Merged
Conversation
The drawer predates the rounded application content frame, so it read as a detached square panel against the new top navigation. Now it mirrors the content frame: rounded top-left and bottom-left corners, a 1px border on every visible edge (border-box so the bottom corner stays on screen), and the resize-handle highlight inset from the corners so it tracks the straight run of the edge. The enter animation now slides and fades as one rigid unit with a no-overshoot deceleration curve (an overshooting curve would briefly detach the drawer from the viewport's right edge) and respects prefers-reduced-motion. The overlay planes clip instead of hide overflow so an autofocus scroll-reveal can never offset an entering overlay mid-slide.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
dosubot
Bot
added
the
size:M
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Drawerpredates the rounded application content frame, so it rendered as a detached square panel that didn't cleanly align with the top navigation. This brings it in line with the app frame (GitHub-drawer style):--global-rounding-mediumtop-left and bottom-left corners and a 1px border on every visible edge (top/left/bottom), hugging the bottom of the top nav exactly.box-sizing: border-boxkeeps the bottom corner on screen now that vertical borders exist.cubic-bezier(0.16, 1, 0.3, 1)) — an overshooting curve would briefly detach the drawer from the viewport's right edge. Respectsprefers-reduced-motion.overflow: clipinstead ofhidden, so an autofocus scroll-reveal inside an entering overlay can never scroll the plane and permanently offset a transform slide-in.Outside the application frame (
data-frame-hosted="false", e.g. Storybook/tests) the drawer keeps its full-window, square-edged appearance.Testing
pnpm fmt,pnpm lint,pnpm typecheck, and all 24 overlay unit tests pass.