ci: skip package suites on bookkeeping-only changes - #15545
Open
RogerHYang wants to merge 1 commit into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
A release PR that only bumps a version and a changelog has nothing for the Python or Playwright suites to exercise. The skip is decided from the changed-file list rather than a branch name or label: the required aggregators report success when their jobs skip, so a signal the PR author picks would let any PR merge untested. Dependency metadata (pyproject.toml, uv.lock) stays outside the allowlist, since those change what actually gets installed.
RogerHYang
force-pushed
the
roger/ci-skip-release-prs
branch
from
August 21, 2026 00:56
9eb1128 to
be371d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip the Python package suites (
phoenix,phoenix_client,phoenix_evals,phoenix_otel) and the Playwright e2e suite when every changed file is release bookkeeping.A root release PR changes exactly three files — there is nothing in it for those suites to exercise:
Why it is decided by content, not by branch name
Gating on the branch name or a label is the cheaper option and was the first thing I tried. It is a CI bypass:
* CI Requiredaggregators run withif: always()and fail only onfailure/cancelled— a skipped job reports successTogether those mean any author-selectable skip signal lets a PR merge with nothing tested: name your branch
release-please--branches--anything, and every suite skips while the required checks still go green. So the skip is decided frompaths-filter's changed-file list against an explicit allowlist:An empty file list fails closed and runs everything.
What deliberately still runs
pyproject.tomlanduv.lockare not allowlisted. A subpackage release PR bumps itspyproject.tomland regeneratesuv.lock, and those change what actually gets installed — so those releases keep running the full suites. Same formigrations,ddl,uv_lock,ipynbandprompts, whose filter outputs are untouched here.Verification
Run against the real file lists of existing release PRs plus hostile cases:
Interaction with #15544
#15544 combines the per-package release PRs into one. After it lands, any release including a subpackage carries that subpackage's
pyproject.tomlanduv.lock, so this skip will fire only on root-only releases. That is the common case, and the narrowing is the correct behaviour rather than something to widen the allowlist for. The two PRs are independent and can land in either order.