Conversation
Member
scx1332
commented
Feb 19, 2026
- Fix busy loop when too much requests for commitments
- Fix misleading and wrong error type (it give me hours of debugging pain but should be clear immediately what is wrong)
- Increased limits for commitments
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to increase size limits for alternative data availability (AltDA) commitments from ~130KB to 10-11MB for testing purposes, fix a busy loop when max concurrent DA requests are reached, and correct error handling for commitment type mismatches.
Changes:
- Increased MaxFrameLen from 1MB to 11MB and MaxInputSize from ~130KB to 10MB
- Added error handling for commitment type mismatches with a new error type
- Added sleep to prevent busy looping when max concurrent DA requests are reached
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| op-node/rollup/derive/frame.go | Increased MaxFrameLen from 1MB to 11MB for testing |
| op-alt-da/params.go | Increased MaxInputSize from ~130KB to 10MB for testing |
| op-node/rollup/derive/altda_data_source.go | Added error handling for commitment type mismatch |
| op-alt-da/damgr.go | Introduced new ErrCommitmentTypeMismatch error type |
| op-batcher/batcher/driver.go | Added warning log and 1-second sleep to prevent busy looping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.