Skip to content

Comments

Increased limits for commitments#16

Open
scx1332 wants to merge 9 commits intodevelopfrom
scx1332/patches
Open

Increased limits for commitments#16
scx1332 wants to merge 9 commits intodevelopfrom
scx1332/patches

Conversation

@scx1332
Copy link
Member

@scx1332 scx1332 commented Feb 19, 2026

  • Fix busy loop when too much requests for commitments
  • Fix misleading and wrong error type (it give me hours of debugging pain but should be clear immediately what is wrong)
  • Increased limits for commitments

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to increase size limits for alternative data availability (AltDA) commitments from ~130KB to 10-11MB for testing purposes, fix a busy loop when max concurrent DA requests are reached, and correct error handling for commitment type mismatches.

Changes:

  • Increased MaxFrameLen from 1MB to 11MB and MaxInputSize from ~130KB to 10MB
  • Added error handling for commitment type mismatches with a new error type
  • Added sleep to prevent busy looping when max concurrent DA requests are reached

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
op-node/rollup/derive/frame.go Increased MaxFrameLen from 1MB to 11MB for testing
op-alt-da/params.go Increased MaxInputSize from ~130KB to 10MB for testing
op-node/rollup/derive/altda_data_source.go Added error handling for commitment type mismatch
op-alt-da/damgr.go Introduced new ErrCommitmentTypeMismatch error type
op-batcher/batcher/driver.go Added warning log and 1-second sleep to prevent busy looping

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

scx1332 and others added 8 commits February 23, 2026 12:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant