Skip to content

fix bug where BTL extension extends relative to the current block #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
draganm merged 2 commits into from
Feb 20, 2026
Merged

fix bug where BTL extension extends relative to the current block #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b60fb3
fix bug where BTL extension extends relative to the current block
draganm Feb 20, 2026
b8f030a
fix tests
draganm Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pusher/push_iterator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ var _ = Describe("PushIterator", func() {
return err
}
newExpiration := row.NumericAttributes.Values["$expiration"]
Expect(newExpiration).To(Equal(uint64(1200)))
Expect(newExpiration).To(Equal(uint64(1600)))
return nil
})
Expect(err).NotTo(HaveOccurred())
Expand Down
6 changes: 3 additions & 3 deletions sqlitestore.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,13 @@ func (s *SQLiteStore) FollowEvents(ctx context.Context, iterator arkivevents.Bat

oldNumericAttributes := latestPayload.NumericAttributes

newToBlock := block.Number + operation.ExtendBTL.BTL
oldExpiration := oldNumericAttributes.Values["$expiration"]

newToBlock := oldExpiration + operation.ExtendBTL.BTL

numericAttributes := maps.Clone(oldNumericAttributes.Values)
numericAttributes["$expiration"] = uint64(newToBlock)

oldExpiration := oldNumericAttributes.Values["$expiration"]

id, err := st.UpsertPayload(ctx, store.UpsertPayloadParams{
EntityKey: key,
Payload: latestPayload.Payload,
Expand Down
4 changes: 2 additions & 2 deletions sqlitestore_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@ var _ = Describe("SQLiteStore", func() {
row, err := q.GetPayloadForEntityKey(ctx, key.Bytes())
Expect(err).NotTo(HaveOccurred())
newExpiration := row.NumericAttributes.Values["$expiration"]
Expect(newExpiration).To(Equal(uint64(1200))) // 200 + 1000
Expect(newExpiration).To(Equal(uint64(1600)))

// Verify old expiration bitmap is removed
oldExpBitmap, err := q.EvaluateNumericAttributeValueEqual(ctx, store.EvaluateNumericAttributeValueEqualParams{
Expand All @@ -610,7 +610,7 @@ var _ = Describe("SQLiteStore", func() {
// Verify new expiration bitmap exists
newExpBitmap, err := q.EvaluateNumericAttributeValueEqual(ctx, store.EvaluateNumericAttributeValueEqualParams{
Name: "$expiration",
Value: 1200,
Value: 1600,
})
Expect(err).NotTo(HaveOccurred())
Expect(newExpBitmap.ToArray()).To(HaveLen(1))
Expand Down