-
Notifications
You must be signed in to change notification settings - Fork 1
Added factory service #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Arkobat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense with a factory method, but we should probably use the IHttpClientFactory to create the client.
|
Looks good 👍 And add a unit tests that verifies we can use the |
…sure the ListProjects call works when creating the service via factory.
|
@Arkobat I added a simple unit test that just ensures it can get the list of projects, so it works with my API key. Obviously I can't run your other tests since I don't have a key in your Localazy account. |
|
That is perfect @ebrob |
There are some use cases where an initializer isn't the best way to initialize.