Unit tests #221
Open
Unit tests #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #212 from ArtifexSoftware/unit-tests
jamie-lemon
requested changes
Nov 3, 2025
There was a problem hiding this comment.
Generally okay but I have one issue.
Thought the entire Page class I see:
PdfDocument pdf = page.doc();
&
PdfDocument pdfDoc = page.doc();
&
PdfDocument pageDoc = page.doc();
It feels a bit confusing. I think we should stick to one convention here. Maybe just always pdfDoc ?
jamie-lemon
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where the PdfDocument object was not being properly disposed.
The dispose() call has now been added wherever it is required.