Skip to content

Fix a segmentation fault in mutool clean #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −3
Open

Fix a segmentation fault in mutool clean #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions source/pdf/pdf-clean-file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,11 +495,17 @@ void pdf_clean_file(fz_context *ctx, char *infile, char *outfile, char *password
const char *pagelist = argv[argidx];

while ((pagelist = fz_parse_page_range(ctx, pagelist, &spage, &epage, pagecount)))
{
if (len + (epage - spage + 1) >= cap)
{
/*
fix segfault on call
'mutool clean mupdf_explored.pdf test.pdf 220-100'
segfault happens if startpage > endpage
*/
int pagedelta = epage >= spage ? epage-spage : spage-epage;
if (len + (pagedelta + 1) >= cap)
{
int n = cap ? cap * 2 : 8;
while (len + (epage - spage + 1) >= n)
while (len + (pagedelta + 1) >= n)
n *= 2;
pages = fz_realloc_array(ctx, pages, n, int);
cap = n;
Expand Down