Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master fix jerrycanrefuel #686

Merged
merged 3 commits into from May 28, 2020
Merged

Master fix jerrycanrefuel #686

merged 3 commits into from May 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 28, 2020

Resolves #685

Changes proposed in this pull request:

  • commented out setting life_action_inUse and life_interrupted within exitWith inside the loop

  • I have tested my changes and corrected any errors found

cryptearth added 2 commits May 26, 2020 16:17
removed/commented out setting life_action_isUse and life_interruped to false directly within exitWith to trigger if() after the loop to return from it before the full jerrycan is given to inventory
Copy link
Member

@BoGuu BoGuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to just remove these comments all together!

removed commented out stuff as requested
@ghost ghost requested a review from BoGuu May 28, 2020 13:43
@BoGuu
Copy link
Member

BoGuu commented May 28, 2020

Cheers!

@BoGuu BoGuu merged commit 86f766e into AsYetUntitled:master May 28, 2020
@ghost ghost deleted the master-fix-jerrycanrefuel branch May 28, 2020 16:07
Edward-Bakker added a commit to Edward-Bakker/Framework that referenced this pull request Jun 7, 2020
Duplicates AsYetUntitled#686 on v5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant