Skip to content

Don't select more UTXOs than necessary#202

Open
gringokiwi wants to merge 43 commits into
AtomicFinance:masterfrom
gringokiwi:fix-input-supplementation
Open

Don't select more UTXOs than necessary#202
gringokiwi wants to merge 43 commits into
AtomicFinance:masterfrom
gringokiwi:fix-input-supplementation

Conversation

@gringokiwi
Copy link
Copy Markdown

@gringokiwi gringokiwi commented Dec 30, 2025 •
edited
Loading

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Dec 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bf5fa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gringokiwi gringokiwi force-pushed the fix-input-supplementation branch from 3cff900 to 774e6f6 Compare December 30, 2025 15:48
@gringokiwi gringokiwi changed the title Fix UTXO selection, make coinselect method customizable Don't select more UTXOs than necessary Dec 30, 2025
matthewjablack
matthewjablack reviewed Dec 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@matthewjablack matthewjablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good!

Couple nits

Also would be good to have a test for deduplication feature

Comment thread packages/bitcoin-wallet-provider/lib/BitcoinWalletProvider.ts Outdated
Comment thread packages/bitcoin-ddk-provider/lib/BitcoinDdkProvider.ts
@gringokiwi
test: deduplicate UTXOs on InputSupplementationMode.Required
7800509
@gringokiwi
fix: add log for getWalletAddress
6cdb59d
@gringokiwi
chore: remove redundant BigInt conversion
b8a056e
@gringokiwi
feat: add specific error for InputSupplementationMode.None
5aab174
@gringokiwi
test: update expected error
42f7300
@gringokiwi
fix: wrap derivationPath check in try/catch
3cedb2b
@gringokiwi
fix: only do try/catch warning for InputSupplementationMode.None
cf8c2a1
@gringokiwi
feat: add CoinSelectMode enum
86a7de8
@gringokiwi
feat: install coinselect dependency
6459b26
@gringokiwi
feat: custom types for coinselect
ba338e7
@gringokiwi
feat: integrate getCoinSelectFunction into getInputsForDualFunding
78a4c6f
@gringokiwi
feat: add coinSelectMode to GetInputsForAmountWithMode
4fe97f8
@gringokiwi
feat: create bitcoinWithDdk4 mock provider
f2d30e3
@gringokiwi
test: coinselect integration tests
bbc5770
@gringokiwi
chore: remove unneeded exports
68e7d34
@gringokiwi
feat: create runCoinSelect helper
b284e01
matthewjablack
matthewjablack reviewed Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@matthewjablack matthewjablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid, couple nits

BitcoinDdkProvider:3589 coinSelectMode parameters still missing for createDlcOffer and acceptDlcOffer

Also need it in Initialize as well

bennyhodl
bennyhodl requested changes Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bennyhodl bennyhodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits. Overall great job with this!

Comment thread packages/bitcoin-wallet-provider/lib/BitcoinWalletProvider.ts Outdated
Comment thread packages/bitcoin-wallet-provider/lib/BitcoinWalletProvider.ts Outdated
Comment thread packages/bitcoin-wallet-provider/lib/BitcoinWalletProvider.ts Outdated
Comment thread packages/bitcoin-wallet-provider/lib/BitcoinWalletProvider.ts Outdated
bennyhodl
bennyhodl reviewed Jan 8, 2026
View reviewed changes
Comment thread packages/types/lib/models/Input.ts Outdated
@gringokiwi gringokiwi requested a review from bennyhodl January 13, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewjablack matthewjablack matthewjablack left review comments

@bennyhodl bennyhodl Awaiting requested review from bennyhodl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gringokiwi @matthewjablack @bennyhodl