-
Notifications
You must be signed in to change notification settings - Fork 68
Add reconnect button to disconnection notice. #1102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
WisoAltred
wants to merge
8
commits into
master
Choose a base branch
from
reconnection-button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ec00075
Add reconnect button to disconnection notice.
WisoAltred 8d8512e
clang formatting
WisoAltred 65f564a
Remove class from debug_functions, add prompt into AoApplication inst…
WisoAltred 51e41c3
clang formatting 2
WisoAltred d4438e2
clang formatting 3
WisoAltred 81cae16
clang formatting 4
WisoAltred 0198674
Complete connection process
WisoAltred fca3ac1
Add disconnection
WisoAltred File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ class NetworkManager; | |
class Lobby; | ||
class Courtroom; | ||
class Options; | ||
class debug_functions; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs removed |
||
|
||
class VPath : QString | ||
{ | ||
|
@@ -57,6 +58,7 @@ class AOApplication : public QObject | |
~AOApplication(); | ||
|
||
NetworkManager *net_manager; | ||
debug_functions *debug_func; | ||
Lobby *w_lobby = nullptr; | ||
Courtroom *w_courtroom = nullptr; | ||
AttorneyOnline::Discord *discord; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -146,6 +146,8 @@ void NetworkManager::connect_to_server(ServerInfo server) | |
{ | ||
disconnect_from_server(); | ||
|
||
m_last_server = server; | ||
|
||
qInfo().noquote() << QObject::tr("Connecting to %1").arg(server.toString()); | ||
m_connection = new WebSocketConnection(ao_app, this); | ||
|
||
|
@@ -167,6 +169,13 @@ void NetworkManager::disconnect_from_server() | |
} | ||
} | ||
|
||
void NetworkManager::reconnect_to_last_server() | ||
{ | ||
connect(this, &NetworkManager::server_connected, this, &NetworkManager::join_to_server); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs disconnected after rejoining the server. |
||
|
||
connect_to_server(m_last_server); | ||
} | ||
|
||
void NetworkManager::ship_server_packet(AOPacket packet) | ||
{ | ||
if (!m_connection) | ||
|
@@ -188,6 +197,7 @@ void NetworkManager::ship_server_packet(AOPacket packet) | |
|
||
void NetworkManager::join_to_server() | ||
{ | ||
disconnect(this, &NetworkManager::server_connected, this, &NetworkManager::join_to_server); | ||
ship_server_packet(AOPacket("askchaa")); | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't remove these, this snippet is for the execution of the lobby settings when the settings button is pressed.
Currently, pressing it causes a disconnection for the purposes of testing the reconnection button.