Make protocol parameters configurable and harden token operations#310
Merged
Conversation
- Add shared protocol configuration plumbing with defaults, environment/global overrides, and validation - Make fork threshold, burn divisor, and initial escalation deposit configurable through constructors and factory wiring - Introduce safe ERC20 call wrappers and replace vulnerable transfer/transferFrom/approve usages - Add active vault/staged-operation paging APIs and update UI/contracts consumers and tests accordingly
# Conflicts: # solidity/contracts/peripherals/SecurityPoolForker.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/ts/protocolConfig.tswith environment/global overrides and strict validation, exposed through package exports.SafeERC20Opsand replaced direct ERC20approve/transfer/transferFromcalls in Solidity with safe optional-return handling across core protocol flows (Zoltar, SecurityPool, SecurityPoolForker, SecurityPoolMigrationProxy).forkThresholdDivisorandforkBurnDivisorintoZoltarstate and construction, replacing fixed constants.SecurityPoolFactoryandSecurityPoolDeployerintoSecurityPooland using it in escalation deployment.getActiveVaultCount/getActiveVaults,getActiveStagedOperationCount/getActiveStagedOperations) to stabilize UI previews after removals.Testing
bun run format): Not runbun run check): Not runbun run knip): Not runBase:
main→ Head:t3code/f38d6b27