Refactor security pool forker and harden shared artifact freshness checks#311
Merged
Conversation
- Remove direct workspace dependency on `@zoltar/shared` and add explicit shared-build/version freshness checks - Introduce hash-based freshness cache for shared outputs and contract artifacts - Add shared package freshness verification/refresh script and hook it into tsc/test workflows - Split `SecurityPoolForker` into storage and vault-migration base contracts and add migration/storage layout test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SecurityPoolForkerby extracting shared migration logic intoSecurityPoolForkerVaultMigrationBaseand storage layout intoSecurityPoolForkerStorage, reducing duplication and consolidating migration behavior.SecurityPoolForkerStorage.solandSecurityPoolForkerForkData.SecurityPoolForkerinheritance to use the new base contract and switched internal state/event handling to the shared base/storage structures.scripts/ensure-contract-artifacts.mtsby replacing mtime-based checks with deterministic SHA-256 content hashing, plus explicit stale-detection and optional sync modes.scripts/ensure-shared-package-fresh.mjsand integrated shared-package freshness/refresh checks into root scripts for solidity and UI flows.@zoltar/sharedworkspace-style dependency from rootpackage.json/bun.lock, and added new scripted workflows for shared dependency checks and synchronized refresh (check:shared-dependencies,refresh:shared-dependencies,ensure-shared-build).solidity/tests/securityPoolForkerStorageLayout.test.ts).Testing
bun run tscbun run testbun run formatbun run checkbun run knip