fix: resolve 5 SonarQube code quality issues across multiple files

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Fixes 5 SonarQube issues including regex syntax simplification, naming convention violations, redundant code removal, and unused variable warnings. These changes improve code quality and maintainability by adhering to Python conventions and eliminating code smells.

View Project in SonarCloud

---

Fixed Issues

python:S6353 - Use concise character class syntax '\d' instead of '[0-9]'. • MINOR • View issue

Location: discord/message.py:2209

Why is this an issue?

A regular expression is a sequence of characters that specifies a match pattern in text. Among the most important concepts are:

What changed

Replaces the character class '[0-9]' with the more concise equivalent '\d' in the regular expression used for matching Discord mention patterns. This addresses the code smell about using verbose character class syntax instead of the shorthand '\d' for digit matching, making the regex more readable and concise.

--- a/discord/message.py
+++ b/discord/message.py
@@ -2209,1 +2209,1 @@ class Message(PartialMessage, Hashable):
-        result = re.sub(r'<(@[!&]?|#)([0-9]{15,20})>', repl, self.content)
+        result = re.sub(r'<(@[!&]?|#)(\d{15,20})>', repl, self.content)

python:S117 - Rename this parameter "dB" to match the regular expression ^[_a-z][a-z0-9_]*$. • MINOR • View issue

Location: discord/opus.py:461

Why is this an issue?

A naming convention in software development is a set of guidelines for naming code elements like variables, functions, and classes.
Local variables and function parameters hold the meaning of the written code. Their names should be meaningful and follow a consistent and easily recognizable pattern.
Adhering to a consistent naming convention helps to make the code more readable and understandable, which makes it easier to maintain and debug. It also ensures consistency in the code, especially when multiple developers are working on the same project.

What changed

Renames the function parameter dB to db in the set_gain method, making it comply with the snake_case naming convention (matching the regex ^[a-z][a-z0-9]*$). This directly fixes the naming convention violation for the parameter dB. It also indirectly supports fixing the local variable naming issue for dB_Q8, since that variable's computation referenced the old parameter name dB which needed to be updated to db.

--- a/discord/opus.py
+++ b/discord/opus.py
@@ -461,1 +461,1 @@ class Decoder(_OpusStruct):
-    def set_gain(self, dB: float) -> int:
+    def set_gain(self, db: float) -> int:

python:S117 - Rename this local variable "dB_Q8" to match the regular expression ^[_a-z][a-z0-9_]*$. • MINOR • View issue

Location: discord/opus.py:464

Why is this an issue?

A naming convention in software development is a set of guidelines for naming code elements like variables, functions, and classes.
Local variables and function parameters hold the meaning of the written code. Their names should be meaningful and follow a consistent and easily recognizable pattern.
Adhering to a consistent naming convention helps to make the code more readable and understandable, which makes it easier to maintain and debug. It also ensures consistency in the code, especially when multiple developers are working on the same project.

What changed

Renames the local variable dB_Q8 to db_q8, making it comply with the snake_case naming convention (matching the regex ^[a-z][a-z0-9]*$). The original variable name used mixed case (dB_Q8) which violated the project's naming convention for local variables. This hunk also updates the reference from dB to db in the computation expression and in the call to self._set_gain(), ensuring consistency with the parameter rename performed in the other hunk. Together these changes resolve both the local variable naming violation for dB_Q8 and ensure the renamed parameter db is used correctly throughout the method body.

--- a/discord/opus.py
+++ b/discord/opus.py
@@ -464,2 +464,2 @@ class Decoder(_OpusStruct):
-        dB_Q8 = max(-32768, min(32767, round(dB * 256)))  # dB * 2^n where n is 8 (Q8)
-        return self._set_gain(dB_Q8)
+        db_q8 = max(-32768, min(32767, round(db * 256)))  # dB * 2^n where n is 8 (Q8)
+        return self._set_gain(db_q8)

python:S3626 - Remove this redundant return. • MINOR • View issue

Location: discord/state.py:896

Why is this an issue?

Jump statements, such as return, break and continue let you change the default flow of program execution, but jump statements that direct the control flow to the original direction are just a waste of keystrokes.

What changed

Removes a redundant 'return' statement at the end of a function or code block. The 'return' statement was unnecessary because the control flow would naturally exit the block at that point anyway. Removing it eliminates the code smell about redundant jump statements that don't change the default flow of program execution.

--- a/discord/state.py
+++ b/discord/state.py
@@ -896,1 +895,0 @@ class ConnectionState(Generic[ClientT]):
-            return

python:S1481 - Replace the unused local variable "ch_type" with "_". • MINOR • View issue

Location: discord/state.py:882

Why is this an issue?

An unused local variable is a variable that has been declared but is not used anywhere in the block of code where it is defined. It is dead code, contributing to unnecessary complexity and leading to confusion when reading the code. Therefore, it should be removed from your code to maintain clarity and efficiency.

What changed

Replaces the unused local variable 'ch_type' with '_' (underscore). The variable 'ch_type' was assigned from the return value of 'channel_factory(data["type"])' but never used anywhere in the code block. By renaming it to '', the conventional Python placeholder for intentionally unused values, the code smell warning about the unused local variable is resolved.

--- a/discord/state.py
+++ b/discord/state.py
@@ -882,1 +882,1 @@ class ConnectionState(Generic[ClientT]):
-        factory, ch_type = _channel_factory(data['type'])
+        factory, _ = _channel_factory(data['type'])

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.

[sonarqube-agent]

SonarQube Remediation Agent could not fix the CI failures.

Task: 45848a7e-283b-4b93-95c6-585be41a8d7f
Branch: remediate-master-20260525-010119-19a3af3c
Attempt: 1 (of 3)

CI failures escalated for manual fix.
Escalation Reason: The CI failures are overwhelmingly pre-existing and unrelated to the code changes in this diff. The 5 files needing Black reformatting (automod.py, components.py, emoji.py, client.py, channel.py) are NOT in the diff, meaning they were already non-compliant before this change. The unnecessary type:ignore in discord/utils.py:646 is also not in the diff. The Sphinx typing.Union reference failures and the Python 3.14 missing audioop/imghdr module errors are external dependency/infrastructure issues that cannot be fixed with a code patch to this project. The actual code changes (message.py regex tweak, opus.py variable rename, state.py minor cleanup) are trivially correct and unrelated to any of the reported failures. A corrective patch for this diff alone cannot resolve these pre-existing CI issues.

---

Generated by SonarQube Remediation Agent