Bump Roborazzi + QuickEditorBottomSheetTest #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests don't verify the content, just the BottomSheet.
Collaborator
📲 You can test the changes from this Pull Request in Gravatar Demo by scanning the QR code below to install the corresponding build.
|
hamorillo
commented
Jun 11, 2025
|
|
||
| fun screenshotTest(composable: @Composable () -> Unit) { | ||
| captureRoboImage { | ||
| composeRule.setContent { |
Contributor
Author
There was a problem hiding this comment.
I wasn't able to continue using the fun captureRoboImage function. Look like the library does something different 🤷♂️
hamorillo
commented
Jun 11, 2025
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
|
|
||
| <application android:theme="@android:style/Theme.Material.NoActionBar" /> |
Contributor
Author
There was a problem hiding this comment.
Applying that theme to the test app, we prevent some screenshots from having the top bar:
Collaborator
Build environment changeslist! Upgraded Dependencies
com.dropbox.differ:differ:0.3.0, (changed from 0.0.2)
com.dropbox.differ:differ-jvm:0.3.0, (changed from 0.0.2)
io.github.takahirom.roborazzi:io.github.takahirom.roborazzi.gradle.plugin:1.44.0, (changed from 1.26.0)
io.github.takahirom.roborazzi:roborazzi-core:1.44.0, (changed from 1.26.0)
io.github.takahirom.roborazzi:roborazzi-core-jvm:1.44.0, (changed from 1.26.0)
io.github.takahirom.roborazzi:roborazzi-gradle-plugin:1.44.0, (changed from 1.26.0)
org.webjars:webjars-locator-lite:0.0.6, (changed from 0.0.4)tree-\--- io.github.takahirom.roborazzi:io.github.takahirom.roborazzi.gradle.plugin:1.26.0
- \--- io.github.takahirom.roborazzi:roborazzi-gradle-plugin:1.26.0
- +--- io.github.takahirom.roborazzi:roborazzi-core:1.26.0
- | \--- io.github.takahirom.roborazzi:roborazzi-core-jvm:1.26.0
- | +--- com.dropbox.differ:differ:0.0.2
- | | \--- com.dropbox.differ:differ-jvm:0.0.2
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.6.10 -> 2.0.21 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 2.1.0 (*)
- | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
- | +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3
- | | \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.6.3
- | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
- | | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.6.3
- | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.6.3 (c)
- | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.6.3 (c)
- | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 (c)
- | | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.6.3 (c)
- | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22 -> 2.0.21 (*)
- | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.6.3
- | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.6.3
- | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
- | | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.6.3 (*)
- | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22 -> 2.0.21 (*)
- | \--- org.jetbrains.kotlinx:kotlinx-io-core:0.3.3
- | \--- org.jetbrains.kotlinx:kotlinx-io-core-jvm:0.3.3
- | +--- org.jetbrains.kotlinx:kotlinx-io-bytestring:0.3.3
- | | \--- org.jetbrains.kotlinx:kotlinx-io-bytestring-jvm:0.3.3
- | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
- | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
- +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 (*)
- +--- org.webjars:webjars-locator-lite:0.0.4
- | \--- org.jspecify:jspecify:0.3.0
- +--- org.webjars:materializecss:1.0.0
- +--- org.webjars:material-design-icons:4.0.0
- \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+\--- io.github.takahirom.roborazzi:io.github.takahirom.roborazzi.gradle.plugin:1.44.0
+ \--- io.github.takahirom.roborazzi:roborazzi-gradle-plugin:1.44.0
+ +--- io.github.takahirom.roborazzi:roborazzi-core:1.44.0
+ | \--- io.github.takahirom.roborazzi:roborazzi-core-jvm:1.44.0
+ | +--- com.dropbox.differ:differ:0.3.0
+ | | \--- com.dropbox.differ:differ-jvm:0.3.0
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.20 -> 2.0.21 (*)
+ | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+ | +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3
+ | | \--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.6.3
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+ | | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.6.3
+ | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.6.3 (c)
+ | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-json-jvm:1.6.3 (c)
+ | | | +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 (c)
+ | | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.6.3 (c)
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22 -> 2.0.21 (*)
+ | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core:1.6.3
+ | | \--- org.jetbrains.kotlinx:kotlinx-serialization-core-jvm:1.6.3
+ | | +--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+ | | +--- org.jetbrains.kotlinx:kotlinx-serialization-bom:1.6.3 (*)
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.22 -> 2.0.21 (*)
+ | \--- org.jetbrains.kotlinx:kotlinx-io-core:0.3.3
+ | \--- org.jetbrains.kotlinx:kotlinx-io-core-jvm:0.3.3
+ | +--- org.jetbrains.kotlinx:kotlinx-io-bytestring:0.3.3
+ | | \--- org.jetbrains.kotlinx:kotlinx-io-bytestring-jvm:0.3.3
+ | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+ | \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3 (*)
+ +--- org.webjars:webjars-locator-lite:0.0.6
+ | \--- org.jspecify:jspecify:0.3.0
+ +--- org.webjars:materializecss:1.0.0
+ +--- org.webjars:material-design-icons:4.0.0
+ \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.21 (*) |
AdamGrzybkowski
approved these changes
Jun 12, 2025
Contributor
AdamGrzybkowski
left a comment
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Left one suggestion, but other than the LGTM!
| colorScheme = GravatarUiMode.LIGHT, | ||
| modalBottomSheetState = rememberModalBottomSheetState(modalDetents().initialDetent), | ||
| ) { | ||
| Text("Gravatar Quick Editor Bottom Sheet") |
Contributor
There was a problem hiding this comment.
Suggested change
| Text("Gravatar Quick Editor Bottom Sheet") | |
| AvatarPicker( | |
| uiState = AvatarPickerUiState( | |
| email = Email("[email protected]"), | |
| avatarPickerContentLayout = AvatarPickerContentLayout.Horizontal, | |
| emailAvatars = EmailAvatars( | |
| avatars = listOf( | |
| Avatar { | |
| imageUrl = URI.create("https://gravatar.com/avatar/test") | |
| imageId = "1" | |
| rating = Avatar.Rating.G | |
| altText = "alt" | |
| updatedDate = "" | |
| }, | |
| Avatar { | |
| imageUrl = URI.create("https://gravatar.com/avatar/test2") | |
| imageId = "2" | |
| rating = Avatar.Rating.G | |
| altText = "alt" | |
| updatedDate = "" | |
| }, | |
| ), | |
| selectedAvatarId = "1", | |
| ), | |
| ), | |
| onEvent = { }, |
⛏️ We could add the AvatarPicker here for a nicer screenshot that's closer to reality.
Contributor
Author
There was a problem hiding this comment.
Sounds good! Done! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned here, we need to update the Roborazzi version to add some screenshot tests for the BottomSheet.
This PR bumps the version to the last stable. After that, I need to record all the screenshots again; in the majority of them, the difference is just a few pixels. (I guess there is some change about how they renderize the composables or how they create the screenshot).
In others, the entire composable is now visible.
Last commit also added a couple of tests to verify the QuickEditorBottomSheet, but only the BottomSheet, not the context.
Testing Steps