Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little rough on the edges support for installing languages. Attempts to fix #176
Some things worth considering:
is_rtl
method depends on a {language_code}.php file to be present in the languages folder. In that file it looks for a variable defining the text direction. Translations downloaded via the translations api don’t include this file. The only place I found the plugin’s text direction information being used is in the body class filter. This filter could either be adapted to use the WordPress text direction ‘detection’ or be removed completely, as a body class is set when the text direction is rtl,languages
directory). Adding a language without a translation file present would be useful. Eg. I might want to have the admin just in English, but the front end in English, Dutch and German, whose translations would be covered by the Theme’s translation file.