Brute Force Protection: Do not log failed attempt logging on password validation failure

[dkmyta]

Fixes #
Currently when password validation fails during the Account Protection login password detection flow, we throw a unique error, capture it in the wp_login_failed action and redirect accordingly. Just so happens BFP uses this same hook to log failed attempts and currently logs one every time password validation fails. It would take a significant number of failed validations over a short period of time to trigger a BFP block but it can be done. This PR addresses that possibility and ensures that when our particular error is thrown, we will not log that attempt as failed.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

• https://github.com/Automattic/jetpack-scan-team/issues/1720

Does this pull request change what data or activity we track or use?

• No

Testing instructions:

• Checkout this branch in JT
• Load Protect with Account Protection and Brute Force Protection enabled
• Add an error log in Brute_Force_Protection::log_failed_attempt() with the new check this PR adds
• Login with a known compromised password and when redirect to the password detection page refer to your error logs to ensure that BFP returns early and bypasses logging the attempt as failed
• Ensure no regressions in BFP or Account Protection functionality are introduced

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/packages/waf-bfp-no-failed-attempt-logging-on-password-validation-failure branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/packages/waf-bfp-no-failed-attempt-logging-on-password-validation-failure

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

Coverage changed in 6 files. Only the first 5 are listed here.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/protect/src/class-rest-controller.php	0/286 (0.00%)	0.00%	41 💔
projects/packages/account-protection/src/class-account-protection.php	29/49 (59.18%)	-40.82%	20 💔
projects/plugins/jetpack/modules/module-headings.php	210/1022 (20.55%)	0.03%	18 💔
projects/plugins/protect/src/class-jetpack-protect.php	0/176 (0.00%)	0.00%	4 💔
projects/packages/waf/src/class-brute-force-protection.php	4/380 (1.05%)	-0.01%	2 ❤️‍🩹

10 files are newly checked for coverage. Only the first 5 are listed here.

File	Coverage
projects/plugins/jetpack/_inc/client/components/data/query-account-protection-settings/index.jsx	0/8 (0.00%) 💔
projects/plugins/jetpack/_inc/client/security/account-protection.jsx	0/6 (0.00%) 💔
projects/packages/account-protection/src/class-password-strength-meter.php	1/48 (2.08%) 💔
projects/packages/account-protection/src/class-validation-service.php	52/125 (41.60%) ❤️‍🩹
projects/packages/account-protection/src/class-password-manager.php	21/31 (67.74%) 💚

Full summary · PHP report · JS report

_{Add label I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. to override the failing coverage check.}