Skip to content

Boost + wpcomsh: ensure API endpoints are registered #43262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Apr 27, 2025

Fixes HOG-87

Proposed changes:

  • With wpcomsh running, My Jetpack is forced off unless the site owner has chosen the wp-admin interface.
  • If a site has chosen Calypso or not chosen at all, My Jetpack does not init, which means the REST API endpoints are not registered.
  • With Jetpack Boost, the CTA for upgrading relies on the My Jetpack products endpoint to provide information.
  • With the API not available, the link to purchase the upgrade is malformed and not able to be purchased.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • On a site with wpcomsh + Boost, before the patch, visit the Jetpack->Boost page and click the CTA to upgrade.
  • Clicking on the CTA in the modal will take you to the WordPress.com checkout with an error.
  • Try again with the patch.
  • Purchase Boost!

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress labels Apr 27, 2025
Copy link
Contributor

github-actions bot commented Apr 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/hog-87 branch.

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Apr 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Apr 27, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/wpcomsh/class-jetpack-plugin-compatibility.php 0/66 (0.00%) 0.00% 3 ❤️‍🩹

Full summary · PHP report

@kraftbj kraftbj added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 27, 2025
@kraftbj kraftbj self-assigned this Apr 27, 2025
@kraftbj kraftbj requested a review from a team April 27, 2025 17:14
Copy link
Contributor

@donnchawp donnchawp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks for fixing!

@kraftbj kraftbj merged commit 0bd0a0e into trunk Apr 30, 2025
63 checks passed
@kraftbj kraftbj deleted the fix/hog-87 branch April 30, 2025 16:14
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Wpcomsh [Tests] Includes Tests [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants