Skip to content

Appearance menu: Add Additional CSS menu for classic themes #43272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

BogdanUngureanu
Copy link
Contributor

This PR re-adds the Additional CSS submenu item that was removed from Jetpack. The menu is visible only for Atomic sites that are using a classic theme.

Fixes linear DOTCOM-10681

Proposed changes:

  • Bring back Additional CSS in Appearance menu for Atomic sites

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Use Jetpack beta and install this branch on your AT Dev Site
  • Notice that the Additional CSS submenu is now visible in Appearance
  • Click on it
  • Notice that you are redirected to the Additional CSS page
  • Click X (close)
  • Notice you are redirected back to the correct page on your site

@BogdanUngureanu BogdanUngureanu self-assigned this Apr 28, 2025
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/add-additional-css-on-atomic branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/add-additional-css-on-atomic
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/add-additional-css-on-atomic

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Package] Masterbar labels Apr 28, 2025
Copy link
Contributor

github-actions bot commented Apr 28, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 28, 2025
Copy link

jp-launch-control bot commented Apr 28, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/masterbar/src/admin-menu/class-atomic-admin-menu.php 75/162 (46.30%) -2.09% 7 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@BogdanUngureanu BogdanUngureanu requested a review from a team April 29, 2025 13:01
@BogdanUngureanu BogdanUngureanu added I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 29, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 29, 2025
@BogdanUngureanu BogdanUngureanu added [Type] Bug When a feature is broken and / or not performing as intended and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 30, 2025
@BogdanUngureanu
Copy link
Contributor Author

@heavyweight yes, that's expected because we don't want to alter the Core experience. On Simple Sites we also don't display the Additional CSS submenu.

@BogdanUngureanu BogdanUngureanu merged commit 52685d5 into trunk May 6, 2025
74 of 75 checks passed
@BogdanUngureanu BogdanUngureanu deleted the fix/add-additional-css-on-atomic branch May 6, 2025 12:53
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Masterbar [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants