-
Notifications
You must be signed in to change notification settings - Fork 818
Blocks: Enable the Top Posts block for Simple sites WP-Admin #43275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
projects/plugins/jetpack/_inc/lib/class-jetpack-top-posts-helper.php
Outdated
Show resolved
Hide resolved
c629849
to
1192b83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- projects/plugins/jetpack/_inc/lib/class-jetpack-top-posts-helper.php: Language not supported
- projects/plugins/jetpack/changelog/update-fix_top_posts_block_for_simple_sites: Language not supported
- projects/plugins/jetpack/extensions/blocks/top-posts/top-posts.php: Language not supported
projects/plugins/jetpack/_inc/lib/class-jetpack-top-posts-helper.php
Outdated
Show resolved
Hide resolved
In my test, it's still returning random posts for simple sites. I'll take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my test, it's still returning random posts for simple sites. I'll take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The random filled posts are actually expected when there are not enough data.
Fixes #34506.
Proposed changes:
Top Posts & Pages
editor block on the WP-Admin of Simple sites.Other information:
Jetpack product discussion
No.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
bin/jetpack-downloader test jetpack update/fix_top_posts_block_for_simple_sites
.Top Posts & Pages
editor block.