My jetpack: Hide backup failure notice when backups are deactivated #43568

manzoorwanijk · 2025-05-22T10:57:02Z

Currently, in My Jetpack, we show the backup failure notice even if the backups are deactivated manually by HEs via the MC VaultPress.

The notice doesn't make sense to the user, as they have deactivated the backups. Thus, we are getting rid of the notice in that scenario.

Completes MYJP-44

This PR also makes some relevant changes for other improvements like typo fixes and language improvements.

Proposed changes:

Fix typo in backup status usage, which made the notice text almost useless for the user. The correct status is actually "backups-deactivated" (plural) instead of "backup-deactivated" - See wp-content/lib/vaultpress/vaultpress-api-client.php:1782 on wpcom. That bug was introduced in My Jetpack: Add Backup 'needs-attention' red bubble and notice banner #40512.
Fix the grammar and language for the error message. Error messages should not be too technical for the users, as they might not know what a "site attribute" is or what a "general kill switch" is.
Hide the backup failure notice when backups are deactivated

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Prerequisites

Ensure that the site has a backup plan
Ensure that there is no cookie in browser devtools > Application > by name name backup_failure_dismissed. Just delete it if it exists.
Use the below snippet to simulate a failed backup due to backups being deactivated. You can add it to some mu-plugin like tools/docker/mu-plugins/0-snippets.php

Snippet (Click to expand)

add_filter(
	'pre_http_request',
	function ( $response, $parsed_args, $url ) {
		if ( false !== strpos( $url, '/rewind/backups' ) ) {
			return array(
				'response' => array(
					'code' => 200,
				),
				'body'     => wp_json_encode(
					array(
						array(
							'id'           => '717986779',
							'started'      => '2025-05-22 06:35:14',
							'last_updated' => '2025-05-22 06:35:14',
							'status'       => 'backups-deactivated',
							'period'       => '1747895713',
							'is_backup'    => '1',
						),
					)
				),
			);
		}

		return $response;
	},
	10,
	3
);

Steps

On trunk go to My Jetpack
Confirm that you see the notice which displays the error code
We need to test the commits separately to ensure the changes can be tested.
Create a temporary branch from trunk git checkout -b temp
Cheryy pick the commit "Fix typo in backup status" - git cherry-pick f5e6aee
Go to My Jetpack again or reload the page
Confirm that you see the updated error message instead of just the error code
But this message has a typo, and the grammar is not correct - "It appear Backup..."
Now cherry pick the commit "Fix the grammar and language for the error message" - git cherry-pick a233fe8
Reload the My Jetpack page
Confirm that the message is updated and says, "It appears that the backups have been manually deactivated for the site."
Now cherry pick the commit "Hide the notice when backups are deactivated" - git cherry-pick d88d769
Reload the My Jetpack page
Confirm that the notice is no longer visible

Error messages should not be too technical for the users as they might not know what a "site attribute" is or what the heck a "general kill switch" is.

github-actions · 2025-05-22T10:57:50Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/my-jetpack/backup-notice-when-deactivated branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/my-jetpack/backup-notice-when-deactivated

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-05-22T10:58:04Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: June 3, 2025
- Code freeze: June 2, 2025