Skip to content

Forms: Simplify DataViews footer positioning #45894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −54
Closed

Forms: Simplify DataViews footer positioning #45894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-forms-dashboard-dataviews-footer
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Simplify DataViews footer positioning by using default sticky behavior
54 changes: 0 additions & 54 deletions projects/packages/forms/src/dashboard/inbox/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,6 @@
@include mixins.flex-column;
flex: 1 1 60%;

// Optionally, fix the footer to bottom of the page and add margin
// so the last row is not hidden by the footer.
@include mixins.dataviews-footer-spacing;

.dataviews-wrapper {
background: var(--jp-white);
flex-grow: 1;
Expand All @@ -80,25 +76,6 @@
}
}

.dataviews-footer {
position: fixed;
bottom: 0;

// Match .admin-ui-page__header padding
padding-inline: var(--jp-forms-page-padding-inline);

// Compensation for the width of the sidebar
// Set left position when auto-fold is not on the body element.
// Adapted from https://github.com/WordPress/gutenberg/blob/4ea86f891145daa12c8b59b18f02fb9fc4d83c5a/packages/base-styles/_mixins.scss#L183-L218
left: 0;
width: 100%;

@media (min-width: #{ (breakpoints.$break-medium + 1) }) {
left: var(--forms-admin-sidebar-width, variables.$admin-sidebar-width);
width: calc(100% - var(--forms-admin-sidebar-width, variables.$admin-sidebar-width));
}
}

.jp-forms__inbox__author-field {
position: relative;

Expand Down Expand Up @@ -137,37 +114,6 @@
}
}

/*
* Compensation for the width of the sidebar
* Auto fold is when on smaller breakpoints, nav menu auto collapses.
* Adapted from: https://github.com/WordPress/gutenberg/blob/4ea86f891145daa12c8b59b18f02fb9fc4d83c5a/packages/base-styles/_mixins.scss#L183-L218
*/
.auto-fold .jp-forms__inbox__dataviews .dataviews-footer {

@media (min-width: #{ (breakpoints.$break-medium + 1) }) {
left: var(--forms-admin-sidebar-width, variables.$admin-sidebar-width-collapsed);
width: calc(100% - var(--forms-admin-sidebar-width, variables.$admin-sidebar-width-collapsed));
}

@media (min-width: #{ (breakpoints.$break-large + 1) }) {
left: var(--forms-admin-sidebar-width, variables.$admin-sidebar-width);
width: calc(100% - var(--forms-admin-sidebar-width, variables.$admin-sidebar-width));
}
}

/*
* Compensation for the width of the sidebar when the Sidebar
* is manually collapsed.
* Adapted from: https://github.com/WordPress/gutenberg/blob/4ea86f891145daa12c8b59b18f02fb9fc4d83c5a/packages/base-styles/_mixins.scss#L183-L218
*/
.folded .jp-forms__inbox__dataviews .dataviews-footer {
left: 0;

@media (min-width: #{ (breakpoints.$break-medium + 1) }) {
left: var(--forms-admin-sidebar-width, variables.$admin-sidebar-width-collapsed);
width: calc(100% - var(--forms-admin-sidebar-width, variables.$admin-sidebar-width-collapsed));
}
}

/*
* We need to make the available canvas 100% tall. Without this,
Expand Down
Loading