Skip to content

Conversation

@simison
Copy link
Member

@simison simison commented Nov 13, 2025

Proposed changes:

  • Cleans up "related posts" entry (and related options etc queries) from API calls for form feedback posts.
  • Adds new filter to related posts letting developers control what custom post type API calls related posts hooks into

Before, related posts hooks into these:

Screenshot 2025-11-13 at 21 01 31

After the change, it tries to hook into these:

Screenshot 2025-11-13 at 21 01 34

API responses before:

image

API responses after:

image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@simison simison requested a review from a team November 13, 2025 19:07
@github-actions github-actions bot added [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-remove-related-posts branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-remove-related-posts

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 13, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/class-contact-form-plugin.php 451/1341 (33.63%) 0.02% 1 ❤️‍🩹
projects/plugins/jetpack/modules/related-posts/jetpack-related-posts.php 123/845 (14.56%) -0.02% 1 ❤️‍🩹

Full summary · PHP report · JS report

@enejb
Copy link
Member

enejb commented Nov 14, 2025

Should we make sure that related posts never return an array of "non" public post types or have some sort of allow list of post types vs return everything ?

@simison
Copy link
Member Author

simison commented Nov 14, 2025

I'm hesitant to limit it to specific list since people might've built all sorts of things around this with custom post types — but many of the known custom post types by us we could limit it, sure. Different PR for that, tho!

*
* @param array $post_types The post types that are allowed to have related posts.
*/
$post_types = apply_filters( 'jetpack_related_posts_allowed_post_types', $post_types );
Copy link
Member Author

@simison simison Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking if the filter should mention rest_api somewhere, e.g. jetpack_related_posts_rest_api_allowed_post_types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Contact Form [Feature] Related Posts [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review. [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants