-
Notifications
You must be signed in to change notification settings - Fork 841
Update class-jetpack-plugin-compatibility.php - Audit Blocked Plugins Project - Group 1 #46168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In reference to the Audit Blocked Plugins Project - https://linear.app/a8c/project/audit-blocked-plugins-0e4e3a73bb43/overview . This commit covers all plugins reviewed as part of "Group 1" of the project (categories: Email, Backup, and Miscellaneous). Summary of plugin changes here: https://atomicrequests.wordpress.com/2025/07/14/incompatible-plugins-block-outreach-requests-2025/#comment-68191 Some lines were moved to group in proper categories and sort alphabetically. This is to align with other platform code that blocks incompatible plugins.
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
…hpcs-filter/stdin-bootstrap.php" does not exist Run "phpcbf --help" for usage information to try and resolve PHPCS linting test failure.
…etpack-phpcs-filter/stdin-bootstrap.php" does not exist" This reverts commit c7d01e8.
phpcbf to try and resolve PHPCS linting test failure.
phpcbf to try and resolve PHPCS linting test failure.* Update Eslint packages * eslint-config-target-es: Enable new rules * Fix new lints related to JS deps vs dev deps vs peer deps --------- Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Brad Jorsch <[email protected]>
…46159) * Forms: fix the flickring of the dashboard as we move between different * changelog * Fix typo in changelog Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Mikael Korpela <[email protected]> Co-authored-by: Copilot <[email protected]>
…o a non integer (#46141) * Forms: Fix contact form ID computation for non-integer page values Ensures the page number defaults to 1 if $page is not an integer when computing the contact form's ID, preventing potential issues with invalid page values. * changelog * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * user is_numeric instead --------- Co-authored-by: Miguel Lezama <[email protected]> Co-authored-by: Copilot <[email protected]>
|
For those who review this, apologies for the multiple commits. One of the PHPCS linting tests was failing and I found I needed to run |
…#46140) * Forms: Check that the file is previable * Restrict previewable file types to images and PDF Removed support for BMP and TIFF file previews and updated logic to only allow image formats and PDF files to be previewed. Also simplified the previewable file check in Feedback_Field by removing the Jetpack function call. * changelog * Update projects/plugins/jetpack/changelog/fix-preview-only-image-formats Co-authored-by: Copilot <[email protected]> * Update projects/packages/forms/changelog/fix-preview-only-image-formats Co-authored-by: Copilot <[email protected]> * Update projects/packages/forms/src/contact-form/class-feedback-field.php Co-authored-by: Copilot <[email protected]> * Refactor file preview check to use MIME type Replaces file extension-based previewability check with a MIME type-based approach in unauth-file-upload.php. Adds unit tests for is_file_type_previable to ensure correct behavior for various MIME types. * Fix spelling --------- Co-authored-by: Copilot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* set 'from' as title field * changelog
* set background color for the dataviews container * changelog
Co-authored-by: Grzegorz Chudzinski-Pawlowski <>
…#46174) - Add fallback in case of errors loading the improved code editor. - Improve FireFox compatibility by using Firefox-supported getComputedStyle over computedStyleMap. This fixes an error in Firefox that prevented the improved editor from loading.
* Update dependency @wordpress/dataviews to v11 * Update type name in Scan --------- Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Douglas <[email protected]>
|
Decided to create a new clean PR here: #46225 . Closing this one. |
In reference to the Audit Blocked Plugins Project - https://linear.app/a8c/project/audit-blocked-plugins-0e4e3a73bb43/overview . This commit covers all plugins reviewed as part of "Group 1" of the project (categories: Email, Backup, and Miscellaneous).
Summary of plugin changes here: p9F6qB-ijk-p2#comment-68191
Some lines were moved to group in proper categories and sorted alphabetically. This is to align with other platform code that blocks incompatible plugins.
Jetpack product discussion
N/A
Does this pull request change what data or activity we track or use?
No, I don't believe this would apply to the update.
Testing instructions: