Skip to content

Conversation

@upwardmomentum84
Copy link
Contributor

@upwardmomentum84 upwardmomentum84 commented Dec 2, 2025

In reference to the Audit Blocked Plugins Project - https://linear.app/a8c/project/audit-blocked-plugins-0e4e3a73bb43/overview . This commit covers all plugins reviewed as part of "Group 1" of the project (categories: Email, Backup, and Miscellaneous).

Summary of plugin changes here: p9F6qB-ijk-p2#comment-68191

Some lines were moved to group in proper categories and sorted alphabetically. This is to align with other platform code that blocks incompatible plugins.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No, I don't believe this would apply to the update.

Testing instructions:

  1. Create a new Business Plan site, mark it as a WoA Dev site, and take it Atomic.
  2. Build wpcomsh plugin and synchronize to the WoA Dev site
git checkout BRANCH
composer install
WPCOMSH_DEVMODE=1 make clean build
rsync -avze ssh --delete build/wpcomsh [email protected]:htdocs/wp-content/mu-plugins
  1. SSH into the WoA dev site, and run: wp plugin install wp-staging --activate
  2. Navigate to the WoA dev site's /wp-admin/plugins.php page and confirm that WP STAGING can be activated and is not disabled.

In reference to the Audit Blocked Plugins Project - https://linear.app/a8c/project/audit-blocked-plugins-0e4e3a73bb43/overview . This commit covers all plugins reviewed as part of "Group 1" of the project (categories: Email, Backup, and Miscellaneous).

Summary of plugin changes here: https://atomicrequests.wordpress.com/2025/07/14/incompatible-plugins-block-outreach-requests-2025/#comment-68191

Some lines were moved to group in proper categories and sort alphabetically. This is to align with other platform code that blocks incompatible plugins.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/incompatible-plugins-list branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/incompatible-plugins-list
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/incompatible-plugins-list

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Dec 2, 2025
@jp-launch-control
Copy link

jp-launch-control bot commented Dec 2, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@upwardmomentum84 upwardmomentum84 added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Dec 2, 2025
…hpcs-filter/stdin-bootstrap.php" does not exist

Run "phpcbf --help" for usage information to try and resolve PHPCS linting test failure.
…etpack-phpcs-filter/stdin-bootstrap.php" does not exist"

This reverts commit c7d01e8.
@upwardmomentum84 upwardmomentum84 changed the title Update class-jetpack-plugin-compatibility.php - Audit Blocked Plugins Project - Group 1 Used phpcbf to try and resolve PHPCS linting test failure. Dec 2, 2025
@upwardmomentum84 upwardmomentum84 changed the title Used phpcbf to try and resolve PHPCS linting test failure. Update class-jetpack-plugin-compatibility.php - Audit Blocked Plugins Project - Group 1 Dec 2, 2025
matticbot and others added 4 commits December 2, 2025 12:38
* Update Eslint packages
* eslint-config-target-es: Enable new rules
* Fix new lints related to JS deps vs dev deps vs peer deps

---------

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Brad Jorsch <[email protected]>
…46159)

* Forms: fix the flickring of the dashboard as we move between different

* changelog

* Fix typo in changelog

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Mikael Korpela <[email protected]>
Co-authored-by: Copilot <[email protected]>
…o a non integer (#46141)

* Forms: Fix contact form ID computation for non-integer page values

Ensures the page number defaults to 1 if $page is not an integer when computing the contact form's ID, preventing potential issues with invalid page values.

* changelog

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* user is_numeric instead

---------

Co-authored-by: Miguel Lezama <[email protected]>
Co-authored-by: Copilot <[email protected]>
@upwardmomentum84 upwardmomentum84 added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Dec 2, 2025
@upwardmomentum84
Copy link
Contributor Author

For those who review this, apologies for the multiple commits. One of the PHPCS linting tests was failing and I found I needed to run phpcbf to autofix the spacing issues. I did that but then Git/GitHub Desktop made a commit using an error message which I then reverted. Anyway, turns out I needed to get the parallel-lint tool installed on my machine using composer.

edanzer and others added 8 commits December 2, 2025 13:27
…#46140)

* Forms: Check that the file is previable

* Restrict previewable file types to images and PDF

Removed support for BMP and TIFF file previews and updated logic to only allow image formats and PDF files to be previewed. Also simplified the previewable file check in Feedback_Field by removing the Jetpack function call.

* changelog

* Update projects/plugins/jetpack/changelog/fix-preview-only-image-formats

Co-authored-by: Copilot <[email protected]>

* Update projects/packages/forms/changelog/fix-preview-only-image-formats

Co-authored-by: Copilot <[email protected]>

* Update projects/packages/forms/src/contact-form/class-feedback-field.php

Co-authored-by: Copilot <[email protected]>

* Refactor file preview check to use MIME type

Replaces file extension-based previewability check with a MIME type-based approach in unauth-file-upload.php. Adds unit tests for is_file_type_previable to ensure correct behavior for various MIME types.

* Fix spelling

---------

Co-authored-by: Copilot <[email protected]>
* set 'from' as title field

* changelog
* set background color for the dataviews container

* changelog
Co-authored-by: Grzegorz Chudzinski-Pawlowski <>
…#46174)

- Add fallback in case of errors loading the improved code editor.
- Improve FireFox compatibility by using Firefox-supported getComputedStyle over computedStyleMap.
  This fixes an error in Firefox that prevented the improved editor from loading.
* Update dependency @wordpress/dataviews to v11
* Update type name in Scan

---------

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Douglas <[email protected]>
@upwardmomentum84
Copy link
Contributor Author

Decided to create a new clean PR here: #46225 .

Closing this one.

@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Actions GitHub actions used to automate some of the work around releases and repository management Admin Page React-powered dashboard under the Jetpack menu [Block] AI Chat [Block] Contact Form Form block (also see Contact Form label) [Block] Donations [Block] Eventbrite [Block] Map [Block] Paid Content aka Premium Content [Block] Podcast Player [Block] Story [Block] VideoPress [Boost Feature] Cloud CSS [Boost Feature] Image CDN aka Photon [Boost Feature] Lcp [Boost Feature] Page Cache Docker Docs E2E Tests [Feature] Ad [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Feature] Comments [Feature] Contact Form [Feature] Extra Sidebar Widgets [Feature] Google Analytics [Feature] Google Fonts [Feature] Infinite Scroll [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Feature] Publicize Now Jetpack Social, auto-sharing [Feature] Sharing Post sharing, sharing buttons [Feature] Shortcodes / Embeds [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Feature] Theme Tools [Feature] VideoPress A feature to help you upload and insert videos on your site. [Feature] WooCommerce Analytics [Focus] Compatibility Ensuring our products play well with third-parties [mu wpcom Feature] Agents Manager [mu wpcom Feature] Code Editor [mu wpcom Feature] Help Center [mu wpcom Feature] Launchpad [mu wpcom Feature] Marketing [mu wpcom Feature] Newspack Blocks [mu wpcom Feature] Replace Site Visibility [mu wpcom Feature] Verbum Comments Verbum, a better comment experience, app developed in the mu-wpcom plugin [mu wpcom Feature] Wpcom Admin Bar [mu wpcom Feature] Wpcom Block Description Links [mu wpcom Feature] Wpcom Block Editor Nux [mu wpcom Feature] Wpcom Command Palette [mu wpcom Feature] Wpcom Dashboard Widgets [mu wpcom Feature] Wpcom Global Styles [mu wpcom Feature] Wpcom Imports [mu wpcom Feature] Wpcom Media [mu wpcom Feature] Wpcom Options General [mu wpcom Feature] Wpcom Sidebar Notice [Plugin] Wpcomsh [Project] All the things! RNA [Tests] Includes Tests [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Projects

None yet

Development

Successfully merging this pull request may close these issues.