fix(woocommerce): add team name to checkouts for memberships-for-teams #3752
Conversation
naxoc
added
the
[Status] Needs Review
|
Didn't work for me :/ the "resubscribe" flow still fails the same way. Maybe I can send you a dump of my test site |
|
@leogermani woops. My bad. I got the scenarios switched around. Could you try again please? |
There was a problem hiding this comment.
Yes! Not all the scenarios work.
Not sure I was able to test Adam's PR beacuse I don't know what he means by "Customer payment page"....
I agree with your suggestion to group and isolate these fixes for Teams. We have a plugins folder where we put things for third party plugins... but not sure if this one could be one file inside the reder-revenue/woocommerce folder... not a strong opinion
github-actions
bot
added
[Status] Approved
|
Hey @naxoc, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
# [6.0.0-alpha.1](v5.14.2...v6.0.0-alpha.1) (2025-02-20) ### Bug Fixes * **campaigns:** remove placeholder Analytics admin page ([#3729](#3729)) ([abd1bc2](abd1bc2)) * **corrections:** address feedbacks on improving code ([b84fab2](b84fab2)) * **corrections:** improve code formatting ([11ed58c](11ed58c)) * **donations:** handle trashed products and avoid creating dupes ([#3760](#3760)) ([5e78832](5e78832)) * **esp-sync:** transform outgoing dates to site timzeone ([#3728](#3728)) ([77dc361](77dc361)) * **perfmatters:** default for lazyload img setting parent selector ([#3753](#3753)) ([491e335](491e335)) * **recaptcha:** improvements for reCAPTCHA v2 + modal checkout ([#3692](#3692)) ([c4738a7](c4738a7)) * **recaptcha:** no need to scroll to top when showing v2 widget ([#3741](#3741)) ([882d55c](882d55c)) * **woocommerce:** add team name to checkouts for memberships-for-teams ([#3752](#3752)) ([e3661c6](e3661c6)) ### Features * **corrections-modal:** refactor corrections admin UI ([0adac63](0adac63)) * **corrections:** add date handling to corrections and enhance UI ([4c77020](4c77020)) * **corrections:** add site timezone handling logic for correction date ([28d3bb9](28d3bb9)) * **corrections:** update style of modal in the editor ([#3766](#3766)) ([0aee542](0aee542)) * **esp-sync:** queue data events sync to run once ([#3661](#3661)) ([dd2b499](dd2b499)) * fixes and improvements for WooCommerce Subscriptions Gifting ([#3747](#3747)) ([49c4b35](49c4b35)) * handle user nicename change ([#3725](#3725)) ([cb045a3](cb045a3)) * **my-account:** add email change feature flag ([#3758](#3758)) ([21f2c30](21f2c30)) * rate limit adding new payment methods by user ([#3679](#3679)) ([0fd5ea5](0fd5ea5)) ### BREAKING CHANGES * **recaptcha:** shippable product orders will auto-complete by default after this change. * chore: undo unwanted change
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Have you followed the Newspack Contributing guideline?
Does your code follow the WordPress' coding standards and VIP Go coding standards?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Changes proposed in this Pull Request:
This adds some filtering to team name on checkout. Some checkout situations were causing errors. See https://app.asana.com/0/1207572908840041/1209019125448166
Also see #2923 - this is related and some of the code from that was changed to accommodate more scenarios. In testing I found a bunch more scenarios where things break because of the missing team name. The ones I found are described in the testing instructions
Questions
I made some utility functions because we already have custom code that does similar things and the team name repair thing is so widespread.
Should we move the new functions to a specific woo-memberships-for-teams class?
How to test the changes in this Pull Request:
Also see instructions in https://app.asana.com/0/1207572908840041/1209019125448166
you'll need woo subscriptions, memberships, and teams for memberships.
Set up a membership plan and a subscriptions:
Add the subscription product to a checkout button in a page. Visit as a reader and buy it.
Confirm in admin the subscription is created, and a team is created for that user.
As an admin, cancel the subscription.
As that reader,
Other information:
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes, as applicable?
Have you successfully ran tests with your changes locally?