Skip to content

test(e2e): drop the picsum interception from provisioning - #1032

Open
adekbadek wants to merge 1 commit into
mainfrom
remove-e2e-picsum-shim
Open

test(e2e): drop the picsum interception from provisioning#1032
adekbadek wants to merge 1 commit into
mainfrom
remove-e2e-picsum-shim

Conversation

@adekbadek

Copy link
Copy Markdown
Member

All Submissions:

Changes proposed in this Pull Request:

Removes the pre_http_request filter that site-setup.sh installs to answer starter content's featured-image request locally.

The filter arrived in #1003 as the immediate unblock for the nightly, which was timing out because Starter_Content_Generated::add_featured_image() fetched one image per post from a third-party host. #1002 replaced that fetch with a bundled asset, so once the plugin change reaches the sites this script provisions, the filter never matches and the ~50 lines of GD image generation are dead weight.

Do not merge until #1002 is on release. The nightly runs e2e/ from main against a site pinned to the stable channel, and the local e2e-release env mounts the same branch. Both still call the third-party host, so merging early re-exposes the nightly to that dependency. The gate:

git merge-base --is-ancestor bff78d9ed2 origin/release

#1002 is already on alpha, so it should land at the next stable promotion. A version number is not the test here: release is 6.49.2 while main is 6.49.1, and the fix is on neither of those numbers but on the promotion.

How to test the changes in this Pull Request:

  1. Confirm the gate has passed. Run git merge-base --is-ancestor bff78d9ed2 origin/release; echo $?. The result is 0.
  2. Check out this branch.
  3. Provision a local env against release-channel code. Run USE_SETUP=true npx playwright test --project="Vanilla in Desktop Chrome" with SITE_URL pointing at e2e-release.test.
  4. Watch the provisioning output. The posts are created at roughly one per second.
  5. Open a starter-content post. It has a featured image.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable? n/a: this removes test tooling.
  • Have you successfully run tests with your changes locally? bash -n on the edited script; the provisioning run above is the real check, and it needs the gate to have passed first.

🤖 Generated with Claude Code

https://claude.ai/code/session_019naMVH96y256r3QTSMqi2u

@adekbadek
adekbadek force-pushed the remove-e2e-picsum-shim branch from 2c40dad to d101f26 Compare September 4, 2026 08:38
@adekbadek
adekbadek marked this pull request as ready for review September 4, 2026 16:00
@adekbadek
adekbadek requested a review from a team as a code owner September 4, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant