test(e2e): drop the picsum interception from provisioning - #1032
Open
adekbadek wants to merge 1 commit into
Open
test(e2e): drop the picsum interception from provisioning#1032adekbadek wants to merge 1 commit into
adekbadek wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019naMVH96y256r3QTSMqi2u
adekbadek
force-pushed
the
remove-e2e-picsum-shim
branch
from
September 4, 2026 08:38
2c40dad to
d101f26
Compare
adekbadek
marked this pull request as ready for review
September 4, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Removes the
pre_http_requestfilter thatsite-setup.shinstalls to answer starter content's featured-image request locally.The filter arrived in #1003 as the immediate unblock for the nightly, which was timing out because
Starter_Content_Generated::add_featured_image()fetched one image per post from a third-party host. #1002 replaced that fetch with a bundled asset, so once the plugin change reaches the sites this script provisions, the filter never matches and the ~50 lines of GD image generation are dead weight.Do not merge until #1002 is on
release. The nightly runse2e/frommainagainst a site pinned to the stable channel, and the locale2e-releaseenv mounts the same branch. Both still call the third-party host, so merging early re-exposes the nightly to that dependency. The gate:#1002 is already on
alpha, so it should land at the next stable promotion. A version number is not the test here:releaseis 6.49.2 whilemainis 6.49.1, and the fix is on neither of those numbers but on the promotion.How to test the changes in this Pull Request:
git merge-base --is-ancestor bff78d9ed2 origin/release; echo $?. The result is0.USE_SETUP=true npx playwright test --project="Vanilla in Desktop Chrome"withSITE_URLpointing ate2e-release.test.Other information:
bash -non the edited script; the provisioning run above is the real check, and it needs the gate to have passed first.🤖 Generated with Claude Code
https://claude.ai/code/session_019naMVH96y256r3QTSMqi2u