Fix WordPress import crash on posts with YAML-special markdown#234
Merged
Conversation
gray-matter's stringify re-parses the body through its YAML engine, which throws on markdown containing YAML alias syntax (*TL;), leading dashes, and other special chars. The unhandled exception killed the entire import handler — the IPC call never returned, so the modal silently reset with no error message. Replace matter.stringify with a stringifyFrontmatter helper that uses js-yaml to serialize only the frontmatter data, then concatenates the body as a raw string. Move the call inside the existing try-catch so a single bad post gets skipped instead of crashing the whole import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*TL;alias syntax, leading-list items, unquoted colons).gray-matter'sstringifyre-parses the body through its YAML engine, which throws aYAMLExceptionthat escapes the IPC handler — the modal gets no response and silently resets.matter.stringifywith astringifyFrontmatterhelper that usesjs-yaml.dump()for the frontmatter data only, then concatenates the body as a raw string — YAML never touches the markdown.Test plan
*TL;DR*or**TL; DR:**in the body — should import all posts without crashingtitle,wp_post_id,wp_categories, etc.)sources/notes/imported-from-wordpress.mdis written correctlynpm run test:unit— all 503 tests pass🤖 Generated with Claude Code