fix Claude Code sign-in edge cases and stabilize the e2e suite#253
Merged
Conversation
selection-menu, formatting-toolbar and project-checks each failed on a test-side issue: a stale placeholder assertion, a focus check that raced the title's requestAnimationFrame, and an assumption that clicking the active sidebar tab keeps the panel open. global-setup now kills any process from this worktree's out/ before packaging so a leaked app from a crashed run can't make codesign fail and abort the whole next run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fix sets that accumulated on this branch.
Claude Code sign-in
E2E suite stabilization
selection-menu: update a stale placeholder assertion — the composer placeholder is now "Ask for an edit on this file…" since the chat panel became view-agnostic in Add quick actions to editor chat, make DraftChatPanel view-agnostic #219.formatting-toolbar: the arrow-traversal test readactiveElementsynchronously, before the title'srequestAnimationFrame-deferred focus move into the editor; it now polls.project-checks: the test clicked the already-active sidebar tab, which toggles the panel shut, collapsing its rows towidth: 0; it now clicks the rail tab only when it isn't already active.global-setup: kill any process running from this worktree'sout/before packaging, so a leaked Electron app from a crashed run can't make the ad-hoccodesignfail and abort every subsequent run.Test plan
npx playwright test tests/e2e/selection-menu.spec.ts tests/e2e/formatting-toolbar.spec.ts tests/e2e/project-checks.spec.ts— all greennpx playwright test tests/e2e/agent.spec.ts— green (needsANTHROPIC_API_KEY)Known issue, intentionally not fixed here
back-from-editor.spec.ts› "opening another draft while already in the editor" is left failing on purpose. It catches a real product race: when a draft whose filename doesn't match its title is open, its auto-renameonRelPathChangedcan resolve after the user opens a different draft and clobber that draft'srelPath. PinningautoRename: falsein the test would only mask it, so the bug is tracked separately instead.