Speed up latest site creation with a generated SQLite template#3482
Open
chubes4 wants to merge 2 commits into
Open
Speed up latest site creation with a generated SQLite template#3482chubes4 wants to merge 2 commits into
chubes4 wants to merge 2 commits into
Conversation
Collaborator
📊 Performance Test ResultsComparing dfefdd6 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-start.Evidence
11252ms -> 6608ms(-4644ms,-41.3%)9519ms -> 8199ms(-1320ms)46passed,0failed--wp 6.8created/started and reported6.8.5--no-startsafetysvproducedWPLANG=sv_SESupporting rig PR: chubes4/homeboy-rigs#134
Studio issue: #3319
The same SQLite-template idea was also tested against Playground Web startup. It did not materially improve visible startup there (
-1.34%for WP 6.8 and-5.61%for WP 6.4 in local traces), so this PR keeps the optimization Studio-owned and scoped to Studio's default latest create/start path.Validation
npm test -- apps/cli/commands/site/tests/create.test.tsnpx eslint apps/cli/commands/site/create.ts apps/cli/commands/site/tests/create.test.ts scripts/generate-preinstalled-sqlite-template.tsnpm run typechecknpm run cli:build && npm run cli:generate-preinstalled-sqlite-templatehomeboy traceusing the Studio SQLite template comparison rig from Add Studio SQLite template comparison trace chubes4/homeboy-rigs#134Note:
npm -w wp-studio run packagealso passed locally and generated/validated the template. That command mutates the local dependency layout as part of existinginstall:bundlebehavior, so I restored the workspace withnpm installbefore running final typecheck.AI assistance