-
Notifications
You must be signed in to change notification settings - Fork 85
Integration: Add support for the LightSpeed Cache plugin #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sensing a theme 🙂
Is there anything that needs to be done for nginx?
I will check for an NGINX version, but this is still quite early in the progress... sadly |
Improves Litespeed Cache integration by updating htaccess rule management, removing activation/deactivation hooks, and refining option handling. Replaces and enhances integration tests, moving them to phpunit and adding coverage for option state and write failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds integration support for the LiteSpeed Cache plugin to prevent ActivityPub JSON responses from being cached incorrectly. The integration automatically adds Apache rewrite rules to the .htaccess
file and includes a Site Health check to verify proper configuration.
- Adds automatic
.htaccess
rule management for LiteSpeed Cache - Implements Site Health integration to monitor configuration status
- Includes comprehensive test coverage for all functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
File | Description |
---|---|
integration/class-litespeed-cache.php | Core integration class implementing .htaccess rule management, Site Health checks, and configuration tracking |
integration/load.php | Initializes the LiteSpeed Cache integration when plugins are loaded |
tests/phpunit/tests/integration/class-test-litespeed-cache.php | Comprehensive test suite covering .htaccess manipulation, option management, and Site Health checks |
Comments suppressed due to low confidence (1)
integration/class-litespeed-cache.php:1
- Inconsistent capitalization of 'LiteSpeed'. Should be 'LiteSpeed Cache might not be' to match the official product name.
<?php
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Introduces is_plugin_active_with_fallback() to safely check plugin activation status outside admin context. Updates LiteSpeed Cache and Surge integrations to use this utility for improved reliability when checking if dependent plugins are active.
Replaces all instances of 'Litespeed Cache' with 'LiteSpeed Cache' in integration and test files for consistency and correct branding.
Co-authored-by: Copilot <[email protected]>
Refactored the plugin activation check by renaming is_plugin_active_with_fallback to is_plugin_active in functions.php. Updated all references in LiteSpeed Cache and Surge integration classes to use the new function name for consistency and clarity.
This PR adds integration support for the LiteSpeed Cache plugin to prevent ActivityPub JSON responses from being cached incorrectly. The integration automatically adds Apache rewrite rules to the
.htaccess
file and includes a Site Health check to verify proper configuration.Proposed changes:
.htaccess
rule management for LiteSpeed CacheOther information:
Testing instructions:
# BEGIN ActivityPub LiteSpeed Cache
section at the top, before WordPress rulesChangelog entry
Changelog Entry Details
Significance
Type
Message
Add LiteSpeed Cache integration to prevent ActivityPub JSON responses from being cached incorrectly. Includes automatic .htaccess rules and Site Health check to ensure proper configuration.