Skip to content

Conversation

@obenland
Copy link
Member

A few changes I'd suggest for #1683. It felt too much to suggest in inline comments.

Proposed changes:

  • Introduces a static $plugin_slug property for consistent plugin slug usage.
  • Test cases are updated to use the new $plugin_slug property.
  • Only adds site_status_tests filter when the plugin is active.
  • Sets method visibility to private for utility functions.

Introduces a static $plugin_slug property for consistent plugin slug usage, refactors site health test registration, and updates method visibility for internal helpers. Test cases are updated to use the new $plugin_slug property for improved maintainability.
@obenland obenland requested a review from pfefferle October 24, 2025 14:00
@obenland obenland self-assigned this Oct 24, 2025
@github-actions github-actions bot added [Focus] Compatibility Ensuring the plugin plays well with other plugins [Tests] Includes Tests labels Oct 24, 2025
@pfefferle pfefferle merged commit 97a046b into integration/litespeed-cache-support Oct 24, 2025
13 checks passed
@pfefferle pfefferle deleted the suggest/lightspeed-cache-changes branch October 24, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Compatibility Ensuring the plugin plays well with other plugins [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants