Adopt androidx.lifecycle 2.11.0 in the sample app (scoped compileSdk 37) - #1455
Draft
jkmassel wants to merge 1 commit into
Draft
Adopt androidx.lifecycle 2.11.0 in the sample app (scoped compileSdk 37)#1455jkmassel wants to merge 1 commit into
jkmassel wants to merge 1 commit into
Conversation
lifecycle 2.11.0 pulls lifecycle-runtime-compose (minCompileSdk=37) transitively, so the sample app must compile against SDK 37. Add a dedicated example-compileSdk (37) used only by :example:composeApp and :example:androidApp; the published :api:android library and the shared android-compileSdk stay at 36 to preserve the WPAndroid AAR alignment from #1433.
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1455")Built from 2b90868 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump of
androidx.lifecyclefrom2.10.0to2.11.0, originally proposed by Dependabot in #1408. 2.11.0 transitively pullslifecycle-runtime-compose, whose AAR metadata declaresminCompileSdk=37, so the consuming module must compile against SDK 37. Rather than raise the sharedandroid-compileSdk— which would also rebuild the publishedapi/androidAAR against 37 and undo thecompileSdk 36alignment with WPAndroid that #1433 deliberately set — this scopes the SDK 37 bump to the sample-app modules only.Changes
example-compileSdk = "37"version-catalog entry.:example:composeAppand:example:androidAppcompileSdkatexample-compileSdk.android-compileSdkon36, so:api:androidis unchanged and stays aligned with WPAndroid.lifecycle2.10.0→2.11.0.Test plan
:example:androidApp:assembleDebugbuilds againstcompileSdk 37with lifecycle 2.11.0 — confirmed green on Buildkite (scoped variant: build 5933; shared-compileSdk variant: build 5932).publish-wp-api-androidstill compiles:api:androidagainstcompileSdk 36.Changelog
CHANGELOG.mdunder## [Unreleased].Related issues