Add Login Spec #532
Add Login Spec #532
Conversation
jkmassel
force-pushed
the
add/login-scenarios
branch
8 times, most recently
from
a87e570 to
b351665
Compare
jkmassel
force-pushed
the
add/login-scenarios
branch
4 times, most recently
from
68c4b18 to
bc249b1
Compare
wp_api/src/login/url_discovery.rs
Outdated
| } | ||
|
|
||
| // Does the given URL look like it's on a local development environment for the purposes of the Login Spec? | ||
| pub fn is_local_dev_environment_url(parsed_site_url: &ParsedUrl) -> bool { |
There was a problem hiding this comment.
Is this only used by the testing suite? The implementation of this is pretty speculative, so if we need it for testing suite, I'd prefer if it's not part of the public API. I wouldn't mind even having separate implementations in Swift, Kotlin & Rust since it's so simple.
There was a problem hiding this comment.
I'm not sure if it needs to be public API at this point but it is used in two places to figure out which error message to show.
But it's an implementation detail so we can probably hide it from the public API
There was a problem hiding this comment.
I think we'll want to move the code that uses this to Rust and then we can hide it from the API. I am still worried of it being speculative, but maybe we can address that with some naming changes for both the function name and the error message.
wp_api/src/login/url_discovery.rs
Outdated
| } | ||
|
|
||
| /// Does the site look like a WordPress site? | ||
| fn is_wordpress_site(&self) -> bool { |
There was a problem hiding this comment.
If we are adding this helper, we should use it in AutoDiscoveryResult::is_wordpress_site as well.
wp_api/src/login/url_discovery.rs
Outdated
| @@ -224,6 +227,36 @@ impl AutoDiscoveryAttemptResult { | |||
| Err(_) => None, | |||
| } | |||
| } | |||
|
|
|||
| fn is_local_dev_environment(&self) -> bool { | |||
There was a problem hiding this comment.
Please see my comment for is_local_dev_environment_url in this same file.
wp_api/src/login.rs
Outdated
| } | ||
|
|
||
| /// Returns `true` if the site URL looks like a local development environment URL. | ||
| pub fn site_url_is_local_development_environment(&self) -> bool { |
There was a problem hiding this comment.
Please see my suggestion for is_local_dev_environment_url.
|
|
||
| Reference Implementation: http://localhost | ||
|
|
||
| # 3: WordPress Admin URL Entry |
There was a problem hiding this comment.
This says WordPress Admin, but it handles both /wp-login and wp-admin cases, should we rename it?
jkmassel
force-pushed
the
add/login-scenarios
branch
2 times, most recently
from
cd36fa5 to
b35616a
Compare
jkmassel
force-pushed
the
add/login-scenarios
branch
from
f394028 to
7e0c993
Compare
jkmassel
force-pushed
the
add/login-scenarios
branch
2 times, most recently
from
4db0bf9 to
c1983be
Compare
jkmassel
force-pushed
the
move/login-errors-to-rust
branch
from
82ec5ab to
19ebcb2
Compare
jkmassel
force-pushed
the
add/login-scenarios
branch
4 times, most recently
from
7a33972 to
1de057f
Compare
jkmassel
force-pushed
the
add/login-scenarios
branch
from
1de057f to
17c1c30
Compare
Add HTTP basic and Custom REST API prefix cases Use RFC 2119-style writing for simplicity Add rate limited access example Add non-existent site example Add Invalid SSL Cert case Add reference implementations for each case Fix no-https cases
Add Swift tests implementing all scenarios Fix invalid stubs
jkmassel
force-pushed
the
add/login-scenarios
branch
from
17c1c30 to
d5f92d9
Compare
As discussed with @oguzkocer – there are a lot of different things that can happen during login, so let's document them so we can ensure we're testing them for each HTTP implementation (the native Rust one, Apple platforms'
URLSession, and Android)