Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A Dev Sites: Update all Prepare for launch links to lead to the Settings page #100136

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ivan-ottinger
Copy link
Contributor

@ivan-ottinger ivan-ottinger commented Feb 21, 2025

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1836.

Proposed Changes

  • update all Prepare to launch links to lead to https://wordpress.com/sites/settings/site/${ siteSlug }

Why are these changes being made?

  • please see the discussion: p1740103478447579/1739971240.373249-slack-C06JY8QL0TU

Testing Instructions

  1. Check out the PR branch and build the app with yarn start-a8c-for-agencies (or use the related Automattic for Agencies Live link below).

  2. Head over to http://agencies.localhost:3000/sites/ and if you don't have any dev site, create one through the Add sites button.

  3. Once the dev site is created, open the action menu on the side and click the Prepare for launch item. It should get you to https://wordpress.com/sites/settings/site/${ siteSlug }.
    Markup on 2025-02-21 at 11:38:09

  4. Similar button can be found on the Licenses page as well: https://agencies.automattic.com/purchases/licenses.

  5. Now build the app with yarn start (or use the related Calypso Live link below).

  6. Test the Prepare for launch links also in: http://calypso.localhost:3000/sites
    Markup on 2025-02-21 at 11:49:45

  7. In http://calypso.localhost:3000/overview/{site-slug}:
    Markup on 2025-02-21 at 11:48:58

  8. And also in http://calypso.localhost:3000/sites/performance/{site-slug}:
    Markup on 2025-02-21 at 12:07:27

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ivan-ottinger ivan-ottinger self-assigned this Feb 21, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 21, 2025
@ivan-ottinger ivan-ottinger requested a review from a team February 21, 2025 11:49
@ivan-ottinger
Copy link
Contributor Author

(adding @Automattic/yolo for tracking purposes, no need to review)

Copy link
Contributor

@travisw travisw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for the update! 🚀

@travisw
Copy link
Contributor

travisw commented Feb 21, 2025

PS - if you're no longer around for the day I can go ahead an deploy this later.

@travisw travisw merged commit fc9b3a5 into trunk Feb 21, 2025
17 checks passed
@travisw travisw deleted the update/a4a-prepare-for-launch-button-link branch February 21, 2025 21:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants