Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader profile - fix the id fallback case of the username route. #100172

Merged

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Feb 21, 2025

Related to # #100098 (comment) and introduced from #100096

Proposed Changes

Fixes a bug where the /reader/users/{username||id-fallback} route wasnt properly rendering with the id fallback.

  • Updates the action dispatch for the user data to continue using what it did before this when we are not specifically requesting by ID.

Why are these changes being made?

  • I done made more regressions 🙈

Testing Instructions

  • Test the user profile as much as you can to make sure it works.
  • Try `/reader/users/{username||id-fallback}, both with your username and ID, make sure they both work.
  • Make sure /reader/users/id/{userId} continues to work as expected.
  • Test unfindable values in all of the above (non existant usernames and ids).
  • Test the lists tab.
  • Test anything else you can think of around user profile.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner February 21, 2025 18:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 21, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@Addison-Stavlo Addison-Stavlo changed the title fix case where ID in the username route isnt working Reader profile - fix the id fallback case of the username route. Feb 21, 2025
Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@Addison-Stavlo Addison-Stavlo merged commit 825b563 into trunk Feb 21, 2025
15 checks passed
@Addison-Stavlo Addison-Stavlo deleted the fix/id-fallback-for-username-reader-profile-route branch February 21, 2025 19:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants