Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Metal as a default rendering mode for 11.2 #17508

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Nov 14, 2024

What does the pull request do?

For 11.2 we enabled Metal by default on macOS.
But it has several major issues:

  • Resizing has poor performance comparing to OpenGL, see Fix window resize jitter with Metal #17415
  • Metal rendering backend had a memory leak on resizing, which was already fixed.
  • Metal rendering backend has much higher memory consumption on larger window sizes. It's not a leak, as memory is reducing, once window is resized back to smaller sizes.

How was the solution implemented (if it's not obvious)?

Re-enabled OpenGL as a default for 11.2 builds.
Note, this PR targets 11.2 branch directly, and for nightly 11.3 builds we still have metal as default.

@maxkatz6 maxkatz6 merged commit 6a9cf80 into release/11.2 Nov 14, 2024
10 of 12 checks passed
@maxkatz6 maxkatz6 deleted the disable-metal-on-11.2 branch November 14, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant