Sort Dropdown's fuzzy search results by score and fix empty results on reopen#2051
Open
corcoran wants to merge 1 commit intoAvengeMedia:masterfrom
Open
Sort Dropdown's fuzzy search results by score and fix empty results on reopen#2051corcoran wants to merge 1 commit intoAvengeMedia:masterfrom
corcoran wants to merge 1 commit intoAvengeMedia:masterfrom
Conversation
…ts on reopen fzf.js relied on stable Array.sort to preserve score ordering, which is not guaranteed in QML's JS engine. Results appeared in arbitrary order with low-relevance matches above exact matches. The sort comparator now explicitly sorts by score descending, with a length-based tiebreaker so shorter matches rank first when scores are tied. Also fixed Object.assign mutating the shared defaultOpts object, which could cause options to leak between Finder instances. DankDropdown's onOpened handler now reinitializes the search when previous search text exists, fixing the empty results shown on reopen. Added resetSearch() for consumers to clear search state externally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fzf.js relied on stable Array.sort to preserve score ordering, which is not guaranteed in QML's JS engine. Results appeared in arbitrary order with low-relevance matches above exact matches. The sort comparator now explicitly sorts by score descending, with a length-based tiebreaker so shorter matches rank first when scores are tied.
Also fixed Object.assign mutating the shared defaultOpts object, which could cause options to leak between Finder instances.
DankDropdown's onOpened handler now reinitializes the search when previous search text exists, fixing the empty results shown on reopen.
Added resetSearch() for consumers to clear search state externally.