Add DDC monitor support via ddcutil for brightness #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dirold2
commented
Apr 22, 2025
Dirold2
commented
- Implement ddcutil backend for external displays
- Add debounced brightness updates (100ms delay)
- Support async DDC/CI commands with callbacks
- Maintain cache for last known brightness value
- Implement ddcutil backend for external displays - Add debounced brightness updates (100ms delay) - Support async DDC/CI commands with callbacks - Maintain cache for last known brightness value
|
Thanks, will check later. |
- Reduce code size by ~40% while maintaining full functionality - Replace GTK file monitoring with GLib-only polling mechanism - Optimize brightness caching to reduce external process calls - Implement threshold-based change detection to minimize updates - Add efficient error handling with proper resource cleanup - Improve debouncing mechanism for better responsiveness - Simplify backend detection and initialization logic This commit significantly improves performance by reducing subprocess calls and implementing more efficient polling. The service now works without any GTK dependencies, using only GLib for timers and synchronization.
|
Well, I think I've managed to rewrite the code to fully use GLib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.