Restore nightly Axon(iq)Framework compatibility: describe AxoniqPlatformStateManager - #170
Merged
Conversation
…ormStateManager The nightly compatibility build against the rolling io.axoniq.framework snapshot broke: `StateManager` now extends `DescribableComponent`, so the `AxoniqPlatformStateManager` decorator no longer compiles without a `describeTo` implementation. Implement it as `descriptor.describeWrapperOf(delegate)`, matching how the other decorators in this module describe themselves. `DescribableComponent` is declared explicitly on the class rather than relied on through `StateManager`, because the pinned 5.3.0-RC1 does not yet extend it. Declaring it directly keeps `describeTo` a valid `override` against both, so this compiles against the pinned release and the snapshot. Verified `clean verify` against both 5.3.0-RC1 and 5.3.0-SNAPSHOT.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
The nightly compatibility build failed against the rolling
io.axoniq.frameworksnapshot:org.axonframework.modelling.StateManagernow extendsDescribableComponent, so our decorator no longer compiles without adescribeToimplementation.The change landed upstream after #169: the
2026-08-03T09:37nightly was green, and the snapshot jar that breaks is timestamped2026-08-03 14:31.Only the nightly is affected —
main.ymlbuilds against the pinned5.3.0-RC1, which does not yet have this change.The fix
Implement
describeToasdescriptor.describeWrapperOf(delegate), consistent with the other decorators in this module (AxoniqPlatformRepository,InspectionEntityMetamodel, the command/query bus wrappers).DescribableComponentis declared explicitly on the class rather than inherited throughStateManager. This matters: in the pinned5.3.0-RC1the interface is not a supertype ofStateManager, so a bareoverridewould fail to compile there. Declaring it directly makesdescribeToa legitimateoverrideunder both versions, so the pinned build and the nightly agree. The interface itself exists in both, so nothing is version-gated.This mirrors the reasoning already applied in
InspectionEntityMetamodel, and the extra supertype is what upstream requires anyway — it becomes redundant, not wrong, once the snapshot is adopted.Verification
./mvnw -B -U clean verifyrun locally against both versions:5.3.0-RC1(pinned)5.3.0-SNAPSHOT(nightly)Both configurations show the same 4 pre-existing
AxoniqConsoleRSocketClientToxiproxyIntegrationTestawaitility timeouts. These are identical on the pinned RC1 — the exact configuration that passed CI in #169 — so they are local Docker/networking flakiness, not related to this change and not version-dependent. CI should be green.