Skip to content

🗃️ db(postgres): add PostgresEventStorageEngine sample usage #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🗃️ db(postgres): add PostgresEventStorageEngine sample usage #12

wants to merge 5 commits into from

Conversation

@MateuszNaKodach
Copy link
Collaborator

@MateuszNaKodach MateuszNaKodach commented Oct 1, 2025

No description provided.

@smcvb smcvb added Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Type: Feature Use to signal an issue is completely new to the project. labels Oct 6, 2025
@smcvb smcvb requested a review from a team October 6, 2025 07:04
smcvb
smcvb requested changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the feature is nice, the main sample should not use our PostgreSQL Extension. Hence, pushing this towards main seems incorrect to me. Furthermore, the use of the properties file will close this sample off from Spring support. Perhaps it's time we started to have several branches on this repository for the "rough flavors."

@MateuszNaKodach
Copy link
Collaborator Author

MateuszNaKodach commented Nov 6, 2025

Although the feature is nice, the main sample should not use our PostgreSQL Extension. Hence, pushing this towards main seems incorrect to me. Furthermore, the use of the properties file will close this sample off from Spring support. Perhaps it's time we started to have several branches on this repository for the "rough flavors."

Personally, I'd merge that. It just an option, good showcase which present how to configure another EventStorageEngine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smcvb smcvb smcvb requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@MateuszNaKodach MateuszNaKodach

Labels

Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Type: Feature Use to signal an issue is completely new to the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MateuszNaKodach @smcvb