fix(mpris): skip caching base64 cover arts#423
Open
navidmafi wants to merge 1 commit into
Open
Conversation
Owner
|
we should instead handle it and also write that to a file |
Author
|
I thought to myself that since the data is available at demand at no cost (unlike https) there would be no need for caching Is my reasoning incorrect? I will try to adapt this to handle them |
Owner
|
Its not cached for the sake of being cached. It is cached so that it is written to a file which is easier to work with on the user's side through the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes thousands of lines of base64 output splattering all over your terminal.
