Potential fix for code scanning alert no. 5: Uncontrolled data used in path expression - #100
Open
AyushAggarwal1 wants to merge 5 commits into
Open
AyushAggarwal1 wants to merge 5 commits into
AyushAggarwal1 wants to merge 5 commits into
Conversation
…n path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Ayush Aggarwal <ayushaggarwal1136@gmail.com>
✅ Deploy Preview for gstly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AyushAggarwal1
marked this pull request as ready for review
January 13, 2026 09:03
✅ Deploy Preview for gstly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AyushAggarwal1/gst-bill/security/code-scanning/5
Generally, the fix is to constrain
defaultTemplateso that it cannot escape the intended directories. This can be done either by: (a) treating it as a simple filename and sanitizing it (e.g., withsanitize-filename), or (b) allowing limited directory components but enforcing that the resolved path remains within an allowed root (e.g.,public/templatesorpublic/backup-templates) usingpath.resolveand checking the prefix. Here, we want to preserve existing behavior (supportingbackup-templates/...vs regular templates) while securing it, so the second approach is best.Concretely, we can:
const templatesRoot = path.join(process.cwd(), 'public', 'templates');const backupTemplatesRoot = path.join(process.cwd(), 'public', 'backup-templates');defaultTemplatestarts with"backup-templates/". Instead of including that prefix in the user-controlled portion of the path, we should strip it before joining, so user input never controls components above the root directory.path.resolve(root, relativePart)to normalize it and collapse..segments.if (!templatePath.startsWith(root + path.sep))(or equality for the root itself). If it does not, reject the request as invalid.fs.existsSync(templatePath)as before.This preserves the existing functionality (choosing between backup and regular templates) but prevents path traversal via
defaultTemplate.Suggested fixes powered by Copilot Autofix. Review carefully before merging.