Migrate modules#1538
Merged
Merged
Conversation
Migrate ai-generator, temperature-graph, submap-tool, transform-tool and world-configurator from public/modules/ui/*.js to src/controllers/*.ts. Move world parameters (mapSize, latitude, longitude, prec) into the structured options object; .map files store them only in the options JSON, with legacy settings slots read as fallback for old maps. World configurator now owns its dialog markup; locked() is DOM-independent (stored == locked). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ator into migrate-modules-6
…ty and maintainability - Simplified the open function in Transform Tool by extracting event listeners and cleanup logic. - Consolidated input handling functions in Transform Tool for better organization. - Enhanced the World Configurator by creating a dedicated function for dialog HTML generation. - Removed redundant code and improved the structure of event listeners in World Configurator. - Updated input value handling to streamline temperature and map size adjustments.
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
barrulus
added a commit
to barrulus/Fantasy-Map-Generator
that referenced
this pull request
Jul 21, 2026
Syncs the fork onto Azgaar upstream master (tip 73e43d2), pulling in three large refactors — UI-editor migration (Azgaar#1520), pointer/d3.v5 selection replacement (Azgaar#1537), and module migration (Azgaar#1538) — plus market relocation, temperature-unit and dropbox fixes, and the Europe North preset restore. 16 conflicts resolved. Key decisions: - Editor pagination (fork) reconciled with upstream's renderDialog() migration across rivers/routes/cultures/religions/burgs/states overviews; page state kept module-scoped, reset on open/search/sort. - WebGL burg icon/label guards preserved over upstream's select("#id") switch. - Fork CSV exports kept (read pack.* not the DOM) to avoid paginated truncation. - States editor: fork dropdown/demote-picker brush kept over upstream's div.selected mechanism; dropped upstream's in-loop footer accumulators to avoid double-counting the visible page. - Seam-wrapping getWrappedLength kept in routes-generator. - Legacy heightmap/provinces editor JS deleted upstream; fork's Uint32Array burg-array widening and GPU-label capital-zoom fallback ported to the new TS controllers. - Burg-editor trade-role/flying/skyport/altitude and burgs-overview pagination/skyburg markup re-homed from index.html into controller templates. tsc clean, 308 tests pass (1 skipped), production build succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description