Skip to content

Conversation

guipublic
Copy link
Contributor

Description

Resolve noir issue reported here: noir-lang/noir#1934

For variable keccak input, we zero the inputs that are after the requested length.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@guipublic guipublic changed the title Set keccak var inputs to 0 after requested length fix: Set keccak var inputs to 0 after requested length Aug 1, 2023
@ludamad
Copy link
Collaborator

ludamad commented Aug 8, 2023

Note, the preferred way to merge this now is to use https://github.com/AztecProtocol/aztec-packages/blob/master/scripts/migrate_barretenberg_branch.sh from aztec packages repo and migrate the PR there when done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants