-
Notifications
You must be signed in to change notification settings - Fork 6
Update GitHub action #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
changjian-wang
wants to merge
20
commits into
main
Choose a base branch
from
changjian-wang/update-github-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement methods in IAnalyzerTrainingService and IFieldExtractionProModeService to generate Shared Access Signature (SAS) URLs with specified permissions and expiry times. Update integration tests to utilize these methods for dynamic SAS URL creation based on environment variables. Modify AzureContentUnderstandingClient to encapsulate SAS URL generation logic. Ensure necessary namespaces are included for Azure Storage functionality. These changes enhance secure access to Azure Blob Storage for analyzer training and field extraction services.
…r daily execution
…egration test workflow
…gration test workflow
… integration test
…DPOINT and AZURE_APIVERSION across multiple services and tests
…ironment variables
…_KEY across multiple services and tests
… and documents folder within RunAsync method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to how integration tests interact with Azure Blob Storage for training and reference data. The main change is the shift from using static SAS URLs to dynamically generating them using storage account and container names, which enhances security and flexibility. The workflows are also updated to support these changes and to use more consistent environment variable names.
Integration with Azure Blob Storage:
Added
GetTrainingContainerSasUrlAsync
andGetReferenceContainerSasUrlAsync
methods to theIAnalyzerTrainingService
interface and its implementation, allowing dynamic SAS URL generation for specified containers and permissions. (AnalyzerTraining/Interfaces/IAnalyzerTrainingService.cs
,AnalyzerTraining/Services/AnalyzerTrainingService.cs
, [1] [2] [3]Refactored integration tests (
AnalyzerTrainingIntegrationTest
andFieldExtractionProModeIntegrationTest
) to use account and container names from environment variables, and to request SAS URLs via the new service methods instead of relying on static SAS URL strings. (AzureAiContentUnderstanding.Tests/AnalyzerTrainingIntegrationTest.cs
,AzureAiContentUnderstanding.Tests/FieldExtractionProModeIntegrationTest.cs
, [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Workflow and environment updates:
.github/workflows/run_integration_test.yml
with.github/workflows/Run Integration Test.yml
, updating triggers, environment variables, and secrets to match the new dynamic SAS URL approach and use more consistent naming. (.github/workflows/Run Integration Test.yml
,.github/workflows/run_integration_test.yml
, [1] [2]Dependency and configuration improvements:
AzureAiContentUnderstanding.Tests/AnalyzerTrainingIntegrationTest.cs
,AzureAiContentUnderstanding.Tests/FieldExtractionProModeIntegrationTest.cs
, [1] [2]Azure SDK usage:
Azure.Identity
,Azure.Storage.Sas
) to support the new SAS URL generation logic. (AnalyzerTraining/Interfaces/IAnalyzerTrainingService.cs
,AnalyzerTraining/Services/AnalyzerTrainingService.cs
,ContentUnderstanding.Common/AzureContentUnderstandingClient.cs
, [1] [2] [3]Test reliability and flexibility:
AzureAiContentUnderstanding.Tests/AnalyzerTrainingIntegrationTest.cs
, AzureAiContentUnderstanding.Tests/AnalyzerTrainingIntegrationTest.csL17-R23)These changes collectively make integration tests more secure, flexible, and maintainable by removing hardcoded secrets and improving configuration management.