Skip to content

Conversation

@Copennin
Copy link

Purpose

Currently, if a new user tries to follow our quickstart, as is, they won't be able to run the app as the newer version of webpack does not work as we implemented it, originally.

Does this introduce a breaking change?

[X ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?
Updates the quickstart to the latest versioning of webpack and our ACS SDKs

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[X] Other... Please describe:

Versioning update

How to Test

I've updated the README.md for this-
feel free to consolidate the npm run commands into one.

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

participants: [
{
id: { communicationUserId: '<USER_ID>' },
displayName: '<USER_DISPLAY_NAME>'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the > back <USER_DISPLAY_NAME

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will do. Thanks.

@RyanHill-MSFT
Copy link

RyanHill-MSFT commented May 4, 2022

MicrosoftDocs/azure-docs#92063

Copy link

@RyanHill-MSFT RyanHill-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment in the review @Copennin

Copy link

@ProbablePrime ProbablePrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go, with Ryan's comment resolved.

@Copennin
Copy link
Author

Copennin commented Jun 8, 2022

Hi @ProbablePrime, I've made those changes - please let me know if we're good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants