Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templatize: fix error handling during bicep run #1276

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mbukatov
Copy link
Contributor

@mbukatov mbukatov commented Feb 9, 2025

What this PR does

This commit fixes problem with error reporting in templatize tool, which surfaced in case of az bicep build-params ... command failure:

  • it was not clear that it happened during the az bicep run
  • the error from the 'az bicep' run was not captured
  • the 'az bicep' command was run 2 times

Original error:

[19:38:44.855] ERROR: command failed {
  "err": "failed to run ARM step: failed to transform Bicep to ARM: failed to get output from command: exit status 1\n"
}

Fixed error:

TODO

Special notes for your reviewer

WIP, this likely needs some tests

This commit fixes the following problems which sufraced in case of
failure of 'az bicep build-params ...' command:

- when the error was reported, it was not clear that it happened during
  the bicep run
- the error from the 'az bicep' run was not captured
- the 'az bicep' command was run 2 times
@mbukatov mbukatov self-assigned this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant