Skip to content

chore(windows): update e2e tests to check dotnet deprecation #8095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
janenotjung-hue wants to merge 7 commits into
base: main
Choose a base branch
from
+53 −1
Draft

chore(windows): update e2e tests to check dotnet deprecation #8095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d00d25f
update..?
janenotjung-hue Mar 12, 2026
805afd8
updating windows content test
janenotjung-hue Mar 16, 2026
03c6368
update windows_settings.json
janenotjung-hue Mar 16, 2026
9fa972c
resolving copilot comments
janenotjung-hue Mar 16, 2026
c0674b6
Potential fix for pull request finding
janenotjung-hue Mar 16, 2026
efa772b
adding tests to scenario_win_test.go for e2e testing as well
janenotjung-hue Mar 16, 2026
b3ea05b
Merge branch 'janejung/test-check-windows-latest-images' of https://g…
janenotjung-hue Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions e2e/scenario_win_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func Test_Windows2022_AzureNetwork(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand Down Expand Up @@ -106,6 +107,7 @@ func Test_Windows2022Gen2AzureNetwork(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
ValidateFileHasContent(ctx, s, "/AzureData/CustomDataSetupScript.log", "CSEScriptsPackageUrl used for provision is https://packages.aks.azure.com/aks/windows/cse/aks-windows-cse-scripts-current.zip")
},
},
Expand Down Expand Up @@ -273,6 +275,7 @@ func Test_Windows2025(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand All @@ -295,6 +298,7 @@ func Test_Windows2025Gen2(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand Down Expand Up @@ -323,6 +327,7 @@ func Test_Windows2022_SecureTLSBootstrapping_BootstrapToken_Fallback(t *testing.
ValidateWindowsDisplayVersion(ctx, s, "21H2")
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand All @@ -347,6 +352,7 @@ func Test_Windows2022_DisableKubeletServingCertificateRotationWithTags(t *testin
ValidateWindowsDisplayVersion(ctx, s, "21H2")
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand Down Expand Up @@ -374,6 +380,7 @@ func Test_Windows2022_VHDCaching(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand All @@ -397,6 +404,7 @@ func Test_Windows2022Gen2_k8s_133(t *testing.T) {
ValidateWindowsDisplayVersion(ctx, s, "21H2")
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand Down Expand Up @@ -464,6 +472,7 @@ func Test_Windows2022_McrChinaCloud_Windows(t *testing.T) {
ValidateFileHasContent(ctx, s,
`C:\ProgramData\containerd\certs.d\mcr.azk8s.cn\hosts.toml`,
`https://mcr.azk8s.cn`)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand All @@ -489,6 +498,7 @@ func Test_Windows2025Gen2_McrChinaCloud_Windows(t *testing.T) {
ValidateFileHasContent(ctx, s, "/k/kubeletstart.ps1", "--container-runtime=remote")
ValidateWindowsProcessHasCliArguments(ctx, s, "kubelet.exe", []string{"--rotate-certificates=true", "--client-ca-file=c:\\k\\ca.crt"})
ValidateCiliumIsNotRunningWindows(ctx, s)
ValidateDotnetNotInstalledWindows(ctx, s)
ValidateFileExists(ctx, s, `C:\ProgramData\containerd\certs.d\docker.io\hosts.toml`)
ValidateFileExists(ctx, s, `C:\ProgramData\containerd\certs.d\mcr.azk8s.cn\hosts.toml`)
ValidateFileHasContent(ctx, s,
Expand Down Expand Up @@ -524,6 +534,7 @@ func Test_NetworkIsolatedCluster_Windows_WithEgress(t *testing.T) {
// Verify mcr.microsoft.com host config exist
ValidateFileExists(ctx, s, `C:\ProgramData\containerd\certs.d\mcr.microsoft.com\hosts.toml`)
ValidateFileDoesNotExist(ctx, s, `C:\ProgramData\containerd\certs.d\mcr.azk8s.cn\hosts.toml`)
ValidateDotnetNotInstalledWindows(ctx, s)
},
},
})
Expand Down
12 changes: 12 additions & 0 deletions e2e/validators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,6 +724,18 @@ func ValidateWindowsServiceIsNotRunning(ctx context.Context, s *Scenario, servic
fmt.Sprintf("Windows service %s validation failed", serviceName))
}

func ValidateDotnetNotInstalledWindows(ctx context.Context, s *Scenario) {
s.T.Helper()
command := []string{
"$ErrorActionPreference = \"Continue\"",
"$dotnetCmd = Get-Command dotnet -ErrorAction SilentlyContinue",
"if ($dotnetCmd) { $result = & dotnet --list-runtimes 2>&1; if ($LASTEXITCODE -eq 0 -and $result) { throw \".NET runtime is installed but should not be: $result\" } }",
"Write-Host \".NET runtime is not installed\"",
}
execScriptOnVMForScenarioValidateExitCode(ctx, s, strings.Join(command, "\n"), 0,
".NET runtime should not be installed on the Windows node")
}

func ValidateSystemdUnitIsNotFailed(ctx context.Context, s *Scenario, serviceName string) {
s.T.Helper()
command := []string{
Expand Down
31 changes: 30 additions & 1 deletion vhdbuilder/packer/test/windows-vhd-content-test.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,32 @@ function Test-SSHDConfig
}


# Verify no .NET runtime/CLI is present on the VHD
function Test-DotnetNotInstalled
{
Comment on lines +753 to +755
$dotnetCmd = Get-Command dotnet -ErrorAction SilentlyContinue
if (-not $dotnetCmd)
{
Write-OutputWithTimestamp ".NET runtime is not installed on the VHD"
return
}
$result = & dotnet --list-runtimes 2>&1
Comment on lines +756 to +762
if ($LASTEXITCODE -ne 0)
{
Write-ErrorWithTimestamp "Failed to query .NET runtimes via 'dotnet --list-runtimes': $result"
exit 1
}
if ($result)
{
Write-ErrorWithTimestamp ".NET runtime is installed on the VHD but should not be: $result"
exit 1
}
else
{
Write-OutputWithTimestamp ".NET runtime is not installed on the VHD"
}
Comment on lines +757 to +776
}

# Test-ValidateImageBinarySignature create a not-running container from the image to validate the signature of the binaries in the image
function Test-ValidateImageBinarySignature {
# imageBinaryNotSigned is used to record binaries in image that are not signed
Expand Down Expand Up @@ -849,5 +875,8 @@ Test-ToolsToCacheOnVHD
Write-OutputWithTimestamp "Test: ExpandVolumeTask"
Test-ExpandVolumeTask

Write-OutputWithTimestamp "Test: DotnetNotInstalled"
Test-DotnetNotInstalled

Write-OutputWithTimestamp "Test: ValidateImageBinarySignature"
Test-ValidateImageBinarySignature
Test-ValidateImageBinarySignature
Loading