Shorten default timeout of individual calls to backend #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to shorten the default timeout for individual backend calls and safely dispose of the HttpClientTransport.
- Introduces a new check for TaskCanceledException with an InnerException of TimeoutException in the fail-over logic.
- Updates AzureAppConfigurationOptions to implement IDisposable and dispose of the HttpClientTransport instance.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs | Adds a check for TaskCanceledException to improve timeout fail-over handling. |
| src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs | Updates the class to implement IDisposable and disposes of HttpClientTransport to avoid resource leaks. |
…etProvider into ajusupovic/shorten-default-timeout
amerjusupovic
force-pushed
the
ajusupovic/shorten-default-timeout
branch
from
0e77499 to
831adb2
Compare
…etProvider into ajusupovic/shorten-default-timeout
jimmyca15
reviewed
May 2, 2025
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs
Show resolved
Hide resolved
RichardChen820
approved these changes
May 9, 2025
jimmyca15
reviewed
May 9, 2025
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
May 9, 2025
jimmyca15
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of a PR that was previously merged and reverted: #620
This PR adds a way to dispose of the
HttpClientTransportclass that was added, but otherwise the change is intended to be the same.