Skip to content

Conversation

@rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Jan 14, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

  • Standard Draft A2A support
    • Users should now be able to chat with draft versions of A2A workflows
    • These draft runs are tagged appropriately in the run history
  • Consumption Draft request run support
    • Consumption draft workflows with 'request' triggers are able to be run
    • Again tagged as draft runs in run history
  • Fixed a few bugs with the tree log panel component for viewing runs
    • Removed duplicate handoff entries
    • Fixed handoff icon on tools
    • Fixed issue with multiple tool iterations within one agent task

Even though I'm tagging risk as medium, all changes are within preview features with DesignerV2

Impact of Change

  • Users: Standard Draft A2A support, Consumption Draft request trigger support, Tree log bugs are fixed
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@rllyy97

Screenshots/Videos

N/A

@rllyy97 rllyy97 added the risk:medium Medium risk change with potential impact label Jan 14, 2026
@github-actions
Copy link

github-actions bot commented Jan 14, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

⚠️ PR Title

  • Current: feat(DesignerV2): Standard Draft A2A, Consumption Draft Req, Tree log bugs
  • Issue: The title is somewhat terse and mixes multiple scope points (A2A draft chat, consumption draft requests, and tree-log bug fixes). It's readable but could be clearer and more specific about the main user-facing feature. Prefer a single-line imperative summary that lists primary changes in prioritized order.
  • Recommendation: Be explicit and use an imperative style. Example: feat(DesignerV2): Add draft A2A chat support, enable consumption 'request' draft runs, fix run tree log handoff duplicates

Commit Type

  • Properly selected (feature).
  • Only one commit type selected which is correct.

⚠️ Risk Level

  • PR body: Medium (and label risk:medium present).
  • Advised: High — I recommend updating the PR label to risk:high.
  • Why: The code changes affect runtime behavior for workflow runs and authentication/authorization handling (e.g., modifying how callback URLs/auth are used, adding/propagating A2A API keys into URLs, changing noAuth handling in run services). These areas are sensitive: they impact run invocation, potential exposure of keys in URLs, and authorization flows. Please consider a security review and validate integration tests and operational monitoring.

What & Why

  • Current:
    • Standard Draft A2A support
    • Consumption Draft request run support
    • Tree log panel bug fixes (duplicate handoff entries, handoff icon fixes, multiple tool iteration issues)
  • Issue: Content is present and clear at a high level. However, the description should call out security-sensitive behavior (A2A key handling) and any backend contract changes (new draft endpoints, api-version usage).
  • Recommendation: Add one sentence calling out security/authorization changes and where reviewers should look (files/functions). Example addition:
    • "Note: this PR changes how A2A API keys and draft agent-card URLs are constructed and how run services determine noAuth; reviewers should verify key handling, URL-encoding, and auth behavior in libs/logic-apps-shared and Services/WorkflowAndArtifacts.tsx."

⚠️ Impact of Change

  • The Impact section exists but is minimal (Developers/System marked N/A). Given the nature of the changes, Developer and System impacts should be expanded.
  • Recommendation: Expand impact specifics:
    • Users: Draft A2A chat for standard workflows, ability to run consumption draft workflows with request triggers, and more accurate run tree views.
    • Developers: Changes to run services and URL/callback handling (libs/logic-apps-shared/src/designer-client-services/lib/*), new Float/Run button props (isConsumption), and new hooks/queries for draft artifacts; callers may need to handle new function signatures (isDraft param) and ensure cache keys are correct.
    • System: Authentication/authorization behavior for run invocation may change (noAuth flag toggled conditionally) and A2A API key appended to agent-card URLs — impacts logging, telemetry, and potentially security posture.

Test Plan

  • Unit tests added/updated: confirmed in the diff (multiple new spec files). Good.
  • E2E tests: none provided — consider adding E2E or integration tests for draft run flows (especially for consumption run paths and agent chat URLs) or document why E2E isn't necessary.
  • Manual testing: add explicit manual test steps for backend integration scenarios (e.g., running consumption draft with request trigger, verifying run history tags for drafts, verifying agent chat iframe generation and that API keys are not leaked in referer/header logs).

Contributors

  • The PR lists @rllyy97. Good. If more reviewers/contributors assisted, consider calling them out.

Screenshots/Videos

  • Marked N/A — acceptable for these functional/backend changes.

Summary Table

Section Status Recommendation
Title ⚠️ Make title more specific and prioritize items.
Commit Type No change needed.
Risk Level ⚠️ Update label to risk:high and add security justification.
What & Why Add brief note about auth/key handling & files to review.
Impact of Change ⚠️ Expand Developer/System impact details.
Test Plan Add E2E/integration tests or manual steps for backend scenarios.
Contributors Consider adding other contributors if any.
Screenshots/Videos N/A is fine for non-visual changes.

Notes / Action Items (please address before merging):

  1. Update the PR title to be clearer and prioritize features (see recommended title above).
  2. Update the PR risk label to risk:high and add a short explanation in the PR body why risk is high (changes to auth/noAuth flow, appending A2A keys to URLs, changes to run invocation endpoints). This PR currently has risk:medium — I advise High due to auth and potential key exposure changes.
  3. Expand the Impact of Change section to include Developer and System impacts (see suggestions).
  4. Add explicit manual test steps or integration/E2E tests for the following flows:
    • Consumption draft request runs (verify run history tag and successful run invocation).
    • A2A draft chat: verify agent-card URL, that api-key presence is intentional and safe, and that referer/telemetry does not leak keys.
    • Verify new noAuth behavior in StandardRunService/ConsumptionRunService when base URI is an ARM resource id.
  5. Add a brief security note in the PR body explaining why inserting the A2A key into agentCard query is safe (or move to a safer transport if necessary). Consider a short review by security or platform team.

Please update the PR title, risk label, and PR body (impact and test plan) per the above recommendations and re-submit. Thank you for the thorough unit tests and the detailed What & Why — this is a substantial and valuable change set; a little more explicit documentation around auth and system impact will help reviewers and maintainers.


Last updated: Tue, 20 Jan 2026 20:31:53 GMT

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@rllyy97 rllyy97 marked this pull request as ready for review January 20, 2026 17:32
Copilot AI review requested due to automatic review settings January 20, 2026 17:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for running draft workflows in both Standard and Consumption Logic Apps, with specific enhancements for A2A (Agent-to-Agent) workflows. It also fixes several UI bugs in the tree log panel used for viewing workflow runs.

Changes:

  • Enables draft workflow execution for Consumption Logic Apps with request triggers via ARM resource ID authentication
  • Implements draft A2A workflow chat support with proper URL generation for agent card endpoints
  • Fixes tree log panel rendering issues including duplicate handoff entries, icon display, and tool iteration indexing

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
libs/logic-apps-shared/src/designer-client-services/lib/standard/run.ts Code style improvement: moved variable declaration for better readability
libs/logic-apps-shared/src/designer-client-services/lib/consumption/run.ts Added ARM resource ID detection and authentication handling for draft run triggers
libs/logic-apps-shared/src/designer-client-services/lib/base/search.ts Removed unused import (isCustomConnectorId)
libs/designer-v2/src/lib/ui/panel/runTreeView/TreeActionItem.tsx Fixed icon rendering order to prioritize handoff icon over default icons
libs/designer-v2/src/lib/ui/panel/runTreeView/RunTreeView.tsx Fixed tool iteration indexing, removed duplicate handoff entries, corrected parent-child relationships
libs/designer-v2/src/lib/ui/panel/runTreeView/RunTreeView.styles.ts Added minWidth/minHeight to prevent icon squishing
libs/designer-v2/src/lib/ui/FloatingRunButton/index.tsx Added isConsumption prop and conditional URL generation for draft runs
libs/designer-v2/src/lib/ui/FloatingRunButton/chat.tsx Adjusted dialog content margins for better layout
libs/designer-v2/src/lib/ui/FloatingRunButton/tests/floatingRunButton.spec.tsx Added comprehensive unit tests for new isConsumption prop and URL generation
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumptionV2.tsx Implemented draft workflow fetching and enabled draft mode for run button
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/Services/WorkflowAndArtifacts.tsx Enhanced A2A URL generation with proper query parameter handling for draft agent chat

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

3 similar comments
@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@rllyy97 rllyy97 merged commit 9f23da8 into main Jan 20, 2026
13 checks passed
@rllyy97 rllyy97 deleted the riley/draft-a2a-chat branch January 20, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants