-
Notifications
You must be signed in to change notification settings - Fork 96
feat(DesignerV2): Standard Draft A2A, Consumption Draft Req, Tree log bugs #8700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Make title more specific and prioritize items. | |
| Commit Type | ✅ | No change needed. |
| Risk Level | Update label to risk:high and add security justification. |
|
| What & Why | ✅ | Add brief note about auth/key handling & files to review. |
| Impact of Change | Expand Developer/System impact details. | |
| Test Plan | ✅ | Add E2E/integration tests or manual steps for backend scenarios. |
| Contributors | ✅ | Consider adding other contributors if any. |
| Screenshots/Videos | ✅ | N/A is fine for non-visual changes. |
Notes / Action Items (please address before merging):
- Update the PR title to be clearer and prioritize features (see recommended title above).
- Update the PR risk label to
risk:highand add a short explanation in the PR body why risk is high (changes to auth/noAuth flow, appending A2A keys to URLs, changes to run invocation endpoints). This PR currently hasrisk:medium— I adviseHighdue to auth and potential key exposure changes. - Expand the Impact of Change section to include Developer and System impacts (see suggestions).
- Add explicit manual test steps or integration/E2E tests for the following flows:
- Consumption draft request runs (verify run history tag and successful run invocation).
- A2A draft chat: verify agent-card URL, that api-key presence is intentional and safe, and that referer/telemetry does not leak keys.
- Verify new noAuth behavior in StandardRunService/ConsumptionRunService when base URI is an ARM resource id.
- Add a brief security note in the PR body explaining why inserting the A2A key into agentCard query is safe (or move to a safer transport if necessary). Consider a short review by security or platform team.
Please update the PR title, risk label, and PR body (impact and test plan) per the above recommendations and re-submit. Thank you for the thorough unit tests and the detailed What & Why — this is a substantial and valuable change set; a little more explicit documentation around auth and system impact will help reviewers and maintainers.
Last updated: Tue, 20 Jan 2026 20:31:53 GMT
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for running draft workflows in both Standard and Consumption Logic Apps, with specific enhancements for A2A (Agent-to-Agent) workflows. It also fixes several UI bugs in the tree log panel used for viewing workflow runs.
Changes:
- Enables draft workflow execution for Consumption Logic Apps with request triggers via ARM resource ID authentication
- Implements draft A2A workflow chat support with proper URL generation for agent card endpoints
- Fixes tree log panel rendering issues including duplicate handoff entries, icon display, and tool iteration indexing
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/logic-apps-shared/src/designer-client-services/lib/standard/run.ts | Code style improvement: moved variable declaration for better readability |
| libs/logic-apps-shared/src/designer-client-services/lib/consumption/run.ts | Added ARM resource ID detection and authentication handling for draft run triggers |
| libs/logic-apps-shared/src/designer-client-services/lib/base/search.ts | Removed unused import (isCustomConnectorId) |
| libs/designer-v2/src/lib/ui/panel/runTreeView/TreeActionItem.tsx | Fixed icon rendering order to prioritize handoff icon over default icons |
| libs/designer-v2/src/lib/ui/panel/runTreeView/RunTreeView.tsx | Fixed tool iteration indexing, removed duplicate handoff entries, corrected parent-child relationships |
| libs/designer-v2/src/lib/ui/panel/runTreeView/RunTreeView.styles.ts | Added minWidth/minHeight to prevent icon squishing |
| libs/designer-v2/src/lib/ui/FloatingRunButton/index.tsx | Added isConsumption prop and conditional URL generation for draft runs |
| libs/designer-v2/src/lib/ui/FloatingRunButton/chat.tsx | Adjusted dialog content margins for better layout |
| libs/designer-v2/src/lib/ui/FloatingRunButton/tests/floatingRunButton.spec.tsx | Added comprehensive unit tests for new isConsumption prop and URL generation |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumptionV2.tsx | Implemented draft workflow fetching and enabled draft mode for run button |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/Services/WorkflowAndArtifacts.tsx | Enhanced A2A URL generation with proper query parameter handling for draft agent chat |
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/Services/WorkflowAndArtifacts.tsx
Outdated
Show resolved
Hide resolved
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/laDesignerConsumptionV2.tsx
Outdated
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/FloatingRunButton/__tests__/floatingRunButton.spec.tsx
Show resolved
Hide resolved
…es/WorkflowAndArtifacts.tsx Co-authored-by: Copilot <[email protected]>
…gnerConsumptionV2.tsx Co-authored-by: Copilot <[email protected]>
|
📊 Coverage check completed. See workflow run for details. |
3 similar comments
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
…AppsUX into riley/draft-a2a-chat
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Even though I'm tagging risk as medium, all changes are within preview features with DesignerV2
Impact of Change
Test Plan
Contributors
@rllyy97
Screenshots/Videos
N/A