Fix the reserved word issue in Modular for API layer #3191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
changed the title
v-jiaodi
commented
May 14, 2025
packages/typespec-test/test/help/generated/typespec-ts/src/index.ts
Outdated
Show resolved
Hide resolved
MaryGao
reviewed
May 20, 2025
| ); | ||
| expect(normalizeName("break", NameType.Method, true)).to.equal( | ||
| "$break" | ||
| ); |
There was a problem hiding this comment.
- pls help add more UTs in rlc-common.
- Also include UTs in classical client and api operations.
- Also add one test case in smoke.
- Help verify the list among our reserved words and spector operations and help add missing cases in spector
There was a problem hiding this comment.
add missing cases in spector : microsoft/typespec#7413
There was a problem hiding this comment.
could @v-jiaodi try to enableOperationGroup as false to see if it works for special words case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3192